Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change images to scratch #41

Merged
merged 2 commits into from
Feb 11, 2021
Merged

Change images to scratch #41

merged 2 commits into from
Feb 11, 2021

Conversation

khaosdoctor
Copy link
Contributor

Update images on the interceptor and scaler to scratch to further reduce the size

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #38

Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@arschles
Copy link
Collaborator

arschles commented Feb 4, 2021

This looks good. Going to wait until after alpha1 release (Friday) to merge it

@khaosdoctor khaosdoctor changed the title Change interceptor image to scratch Change images to scratch Feb 8, 2021
Copy link
Collaborator

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khaosdoctor I trust you've tested this in a cluster?

@khaosdoctor
Copy link
Contributor Author

khaosdoctor commented Feb 10, 2021

Yep, I have tested it using our scripts in my AKS cluster, but I'll do another test run to make sure

@khaosdoctor
Copy link
Contributor Author

Just gave it a test run and it's working (with the errors from before #47)

Copy link
Collaborator

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @khaosdoctor

@arschles arschles merged commit eaa2be8 into kedacore:main Feb 11, 2021
@khaosdoctor khaosdoctor deleted the scratch-images branch February 11, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change base docker image to scratch
2 participants