Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test in build workflows #429

Merged
merged 10 commits into from
Jun 29, 2022
Merged

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Mar 31, 2022

Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es

As a first step to support ARM64, this PR adds another job after building the images that does a e2e test.
This extra job basically does these actions:

  1. Install KEDA using helm
  2. Install the http-add-on using helm with canary/VERSION tag
  3. Install the sample using helm
  4. Check that the SO generated based on the HTTPScaledObject is ready (.status.Ready == True)
  5. Check that the workload has 0 instances
  6. Do a request
  7. Check that the workload has 1 instance

Note: Latest chart doesn't work with canary tag because right now, canary need an extra configuration that is not merged and released with the chart yet. You can check how it works here

Checklist

Related #364

@JorTurFer JorTurFer changed the title Add an extra job for smoke test WIP - Add an extra job for smoke test Mar 31, 2022
@JorTurFer JorTurFer changed the title WIP - Add an extra job for smoke test WIP - Add smoke test in canary workflow Mar 31, 2022
@JorTurFer JorTurFer changed the title WIP - Add smoke test in canary workflow Add smoke test in canary workflow Mar 31, 2022
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer marked this pull request as ready for review March 31, 2022 22:24
@JorTurFer JorTurFer changed the title Add smoke test in canary workflow Add smoke test in build workflows Mar 31, 2022
Copy link
Collaborator

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JorTurFer looks great! can you pull the scripts into separate files under a top-level tests/ directory or something like that?

@JorTurFer
Copy link
Member Author

Hey!
Sure, tomorrow I'll do it :)

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer changed the title Add smoke test in build workflows Add e2e test in build workflows Apr 12, 2022
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Apr 12, 2022

Hi @arschles ,
I have changed a bit the script to cover also a simple e2e test and not only the smoke test.
You can see it working in this CI and failing (I have provocated a failure not scaling to the target value) in this CI
This PR still requires the new version of the chart with the needed value for working with canary (just to not merge this till the next chart version is released)

JorTurFer and others added 2 commits April 13, 2022 00:51
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
Copy link
Collaborator

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JorTurFer this looks good to me, thanks 👍

@tomkerkhove tomkerkhove enabled auto-merge (squash) June 29, 2022 08:15
@tomkerkhove tomkerkhove merged commit 3ed9b3d into kedacore:main Jun 29, 2022
@JorTurFer JorTurFer deleted the smoke-test branch June 29, 2022 10:29
@JorTurFer
Copy link
Member Author

JorTurFer commented Jun 29, 2022

The test is failing due to this feature is needed in the chart (I wrote it in the PR description xD)
Can we release new chart version?

@v-shenoy
Copy link
Contributor

@JorTurFer I was working on adding e2e and stress tests as a part of this - #238 (Go-based, similar to keda core). But I see that you've added one here. What should I do then @JorTurFer ?

@JorTurFer
Copy link
Member Author

@JorTurFer I was working on adding e2e and stress tests as a part of this - #238 (Go-based, similar to keda core). But I see that you've added one here. What should I do then @JorTurFer ?

If you are introducing e2e using go, go ahead 🙂. I did this several months ago as a pre step for supporting arm builds. My intention was having at least one "happy path", that's why I used bash but obviously, using golang is better :)

@JorTurFer
Copy link
Member Author

In fact, current approach has strong dependency with the helm chart because I used it to simplify the deploy process and that's not the best IMO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants