-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e test in build workflows #429
Conversation
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JorTurFer looks great! can you pull the scripts into separate files under a top-level tests/
directory or something like that?
Hey! |
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Hi @arschles , |
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JorTurFer this looks good to me, thanks 👍
The test is failing due to this feature is needed in the chart (I wrote it in the PR description xD) |
@JorTurFer I was working on adding e2e and stress tests as a part of this - #238 (Go-based, similar to keda core). But I see that you've added one here. What should I do then @JorTurFer ? |
If you are introducing e2e using go, go ahead 🙂. I did this several months ago as a pre step for supporting arm builds. My intention was having at least one "happy path", that's why I used bash but obviously, using golang is better :) |
In fact, current approach has strong dependency with the helm chart because I used it to simplify the deploy process and that's not the best IMO |
Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es
As a first step to support ARM64, this PR adds another job after building the images that does a e2e test.
This extra job basically does these actions:
canary/VERSION
tagHTTPScaledObject
is ready (.status.Ready
== True)Note: Latest chart doesn't work with canary tag because right now, canary need an extra configuration that is not merged and released with the chart yet. You can check how it works here
Checklist
README.md
docs/
directoryRelated #364