Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating interceptor section in developing.md #450

Merged
merged 4 commits into from
May 31, 2022

Conversation

Ritikaa96
Copy link
Contributor

Signed-off-by: Ritikaa96 ritika@india.nec.com

In this document related to development, the two points were made but it is not clear what they are describing here. Can we add a little bit clarity in this one?

here is the reference paragraph:

Any interceptor pod has both a proxy and admin server running inside it. The proxy server is where users send HTTP requests to, and the admin server is for internal use. The admin server runs on a separate port, fronted by a separate Service.

  1. Prompt the interceptor to re-fetch the routing table from the interceptor, or
  2. Print out the interceptor's current routing table (useful for debugging)

also shouldn't the first point be from the operator as the update loop updates the routing table from the ConfigMap that the operator updates as HTTPScaledObjects enter and exit the system.

I changed the least bit of text only adding what seemed to be necessary only, please do let me know if I'm going right here or not.

Checklist

Signed-off-by: Ritikaa96 <ritika@india.nec.com>
@Ritikaa96
Copy link
Contributor Author

Ritikaa96 commented May 16, 2022

Hi, @arschles @tomkerkhove @ajanth97 @asw101 PTAL

docs/developing.md Outdated Show resolved Hide resolved
@tomkerkhove
Copy link
Member

Thank you!

@tomkerkhove tomkerkhove enabled auto-merge (squash) May 31, 2022 07:07
@tomkerkhove tomkerkhove changed the title updating interceptor section in developing.md docs: Updating interceptor section in developing May 31, 2022
@tomkerkhove tomkerkhove disabled auto-merge May 31, 2022 07:11
@tomkerkhove tomkerkhove changed the title docs: Updating interceptor section in developing updating interceptor section in developing.md May 31, 2022
@tomkerkhove tomkerkhove merged commit 8f0598d into kedacore:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants