Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve status conditions #47

Merged
merged 28 commits into from
Feb 26, 2021
Merged

Improve status conditions #47

merged 28 commits into from
Feb 26, 2021

Conversation

khaosdoctor
Copy link
Contributor

@khaosdoctor khaosdoctor commented Feb 4, 2021 •
edited by arschles
Loading

Improve status to conditions

https://github.com/khaosdoctor/http-add-on/pull/1 should be merged into this PR before this PR is merged

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #9
Related to #15 #39

@khaosdoctor
Improve status conditions
5f897ef 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor khaosdoctor mentioned this pull request Feb 4, 2021
Closed
2 tasks
@khaosdoctor khaosdoctor mentioned this pull request Feb 11, 2021
Merged
1 task
@arschles arschles mentioned this pull request Feb 11, 2021
Merged
2 tasks
@arschles @khaosdoctor
refactoring typed Kubernetes clients out
cf89181 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles @khaosdoctor
finishing delete logic
5808ae1 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles @khaosdoctor
removing now-unused code
c86ba10 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles @khaosdoctor
removing commented unused code
76218e7 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
@arschles @khaosdoctor
fixing lint error
8d12273 
Signed-off-by: Aaron Schlesinger <aaron@ecomaz.net>
arschles
arschles requested changes Feb 11, 2021
View reviewed changes
Copy link
Collaborator

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khaosdoctor a few comments here

operator/controllers/suite_test.go Show resolved Hide resolved
pkg/k8s/deployment.go Outdated Show resolved Hide resolved
pkg/k8s/scaledobject.go Outdated Show resolved Hide resolved
scaler/queue_pinger.go Outdated Show resolved Hide resolved
arschles and others added 8 commits February 12, 2021 11:14
@arschles
Merge branch 'main' into improve-conditions
ac676cc 
Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
Sign-off-executed-by: Lucas Santos <lhs.santoss@gmail.com>
Approved-at: Aaron Schlesinger <aaron@ecomaz.net>
@khaosdoctor
Delete test file
5c642c5 
PR #43 will address it

Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Update deployment client
a3cfd98 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Merge branch 'improve-conditions' of github.com:khaosdoctor/http-add-…
47a5bab 
…on into improve-conditions

Signed-off-by:  <>
@khaosdoctor
Update scaled object client
6cd2585 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Add fix notation
d5acebc 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Move FIX to TODO
fddcdee 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Add context to requestCounts
870daeb 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor khaosdoctor requested a review from arschles February 12, 2021 23:06
arschles
arschles requested changes Feb 23, 2021
View reviewed changes
Copy link
Collaborator

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khaosdoctor this is great. I left a few more comments

pkg/k8s/scaledobject.go Outdated Show resolved Hide resolved
pkg/k8s/scaledobject.go Outdated Show resolved Hide resolved
scaler/queue_pinger.go Outdated Show resolved Hide resolved
operator/controllers/suite_test.go Show resolved Hide resolved
arschles and others added 5 commits February 25, 2021 07:19
@arschles
Adding an FAQ (#71)
dac4b9b 
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
Sign-off-executed-by: Lucas Santos <lhs.santoss@gmail.com>
Approved-at: Aaron Schlesinger <aaron@ecomaz.net>
@khaosdoctor
Merge branch 'main' into improve-conditions
47336b8 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Sign-off-executed-by: Lucas Santos <lhs.santoss@gmail.com>
Approved-at: Aaron Schlesinger <aaron@ecomaz.net>
@khaosdoctor
Remove unused code
77e896d 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Use two strings as opposed to interface
ec04831 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Merge branch 'improve-conditions' of github.com:khaosdoctor/http-add-…
2b0763d 
…on into improve-conditions

Signed-off-by:  <>
@khaosdoctor
Revert "Delete test file"
1d6bf15 
This reverts commit 46f4de7.

Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Sign-off-executed-by: Lucas Santos <lhs.santoss@gmail.com>
Approved-at: Aaron Schlesinger <aaron@ecomaz.net>
@khaosdoctor
Restore pkg/k8s/client.go
022aa13 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Sign-off-executed-by: Lucas Santos <lhs.santoss@gmail.com>
Approved-at: Aaron Schlesinger <aaron@ecomaz.net>
@khaosdoctor
Add context to queue pinger
9ed1bbd 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor khaosdoctor requested a review from arschles February 25, 2021 20:26
arschles and others added 6 commits February 25, 2021 17:28
@arschles @khaosdoctor
Adding an FAQ (#71)
e38600d 
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>

Signed-off-by: Aaron Schlesinger <70865+arschles@users.noreply.github.com>
Sign-off-executed-by: Lucas Santos <lhs.santoss@gmail.com>
Approved-at: Aaron Schlesinger <aaron@ecomaz.net>
@khaosdoctor
Revert "Delete test file"
4af0fe2 
This reverts commit 46f4de7.

Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Sign-off-executed-by: Lucas Santos <lhs.santoss@gmail.com>
Approved-at: Aaron Schlesinger <aaron@ecomaz.net>
@khaosdoctor
Restore pkg/k8s/client.go
0d3b629 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
Sign-off-executed-by: Lucas Santos <lhs.santoss@gmail.com>
Approved-at: Aaron Schlesinger <aaron@ecomaz.net>
@khaosdoctor
Add context to queue pinger
3d2831a 
Signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
@khaosdoctor
Merge branch 'improve-conditions' of github.com:khaosdoctor/http-add-…
23316ea 
…on into improve-conditions

Signed-off-by:  <>
@khaosdoctor
Merge branch 'main' into improve-conditions
d31e239
@khaosdoctor
Copy link
Contributor Author

Merging to fix DCO

arschles
arschles approved these changes Feb 26, 2021
View reviewed changes
Copy link
Collaborator

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khaosdoctor this looks great! thanks 💯

@arschles arschles merged commit ebef98e into kedacore:main Feb 26, 2021
@khaosdoctor khaosdoctor deleted the improve-conditions branch March 2, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arschles arschles arschles approved these changes

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

@tomkerkhove tomkerkhove Awaiting requested review from tomkerkhove

@zroubalik zroubalik Awaiting requested review from zroubalik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the status field of HTTPScaledObjects
3 participants
@khaosdoctor @arschles @zroubalik