Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create copy of backoff struct #598

Merged
merged 1 commit into from
Feb 7, 2023
Merged

fix: Create copy of backoff struct #598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/net/dial_context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ type DialContextFunc func(ctx context.Context, network, addr string) (net.Conn,
func DialContextWithRetry(coreDialer *net.Dialer, backoff wait.Backoff) DialContextFunc {
numDialTries := backoff.Steps
return func(ctx context.Context, network, addr string) (net.Conn, error) {
// We need to copy the backoff struct because Step() mutates it but the
// number of steps is never reset.
backoff := backoff

// note that we could test for backoff.Steps >= 0 here, but every call to backoff.Step()
// (below) decrements the backoff.Steps value. If you accidentally call that function
// more than once inside the loop, you will reduce the number of times the loop
Expand Down