Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use registry.k8s.io/e2e-test-images/agnhost instead of arschles/xkcd #693

Merged
merged 5 commits into from
Jun 1, 2023
Merged

feat: Use registry.k8s.io/e2e-test-images/agnhost instead of arschles/xkcd #693

merged 5 commits into from
Jun 1, 2023

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented May 31, 2023 •
edited
Loading

Currently, we are using arschles/xkcd as docker image. This image isn't under our control and it doesn't support ARM64. As we support ARM64 arch.
As there is an image in Kubernetes registry for e2e tests which matches are requirements and it's multi arch, this PR replaces them

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #665

@JorTurFer
feat: Add the code for image and use it
fc2eb4e 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner May 31, 2023 22:22
@JorTurFer JorTurFer enabled auto-merge (squash) May 31, 2023 22:22
JorTurFer added 2 commits June 1, 2023 00:33
@JorTurFer
fix style
2d8901c 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
fix style
0f06693 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@t0rr3sp3dr0
Copy link
Contributor

What about using k8s.gcr.io/e2e-test-images/echoserver instead? It would allow us to check much more on E2E, like that we are sending the proper URL and Headers to the application.

@t0rr3sp3dr0
Copy link
Contributor

t0rr3sp3dr0 commented Jun 1, 2023 •
edited
Loading

There's also the new registry.k8s.io/e2e-test-images/agnhost. It has a lot of different routes that return more structured data: https://github.com/kubernetes/kubernetes/blob/master/test/images/agnhost/netexec/netexec.go#L65.

@JorTurFer
Copy link
Member Author

I didn't know about that, I'm going to take a look ❤️

@JorTurFer
use k8s images
703f111 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer JorTurFer changed the title feat: Add the code for ghcr.io/kedacore/http-add-on-demo-server image and use it feat: Use registry.k8s.io/e2e-test-images/agnhost instead of arschles/xkcd Jun 1, 2023
@JorTurFer
remove unintended changes
d44953d 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
Copy link
Member Author

PTAL @t0rr3sp3dr0

t0rr3sp3dr0
t0rr3sp3dr0 approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@t0rr3sp3dr0 t0rr3sp3dr0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JorTurFer JorTurFer disabled auto-merge June 1, 2023 20:29
@JorTurFer JorTurFer merged commit f06f975 into kedacore:main Jun 1, 2023
@JorTurFer JorTurFer deleted the add-sample-image branch June 1, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0rr3sp3dr0 t0rr3sp3dr0 t0rr3sp3dr0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XKCD addon is missing arm64
2 participants
@JorTurFer @t0rr3sp3dr0