Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the proxy RawPath to original requests RawPath #873

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

worldspawn
Copy link
Contributor

@worldspawn worldspawn commented Jan 4, 2024

I have set the RawPath of what I think is the forward request to that of the original request with the expectation escaped values in the request path are forwarded unmodified (still escaped).

Checklist

Fixes #

#864

@worldspawn worldspawn requested a review from a team as a code owner January 4, 2024 04:59
Signed-off-by: Sam Critchley <critchley.sj@gmail.com>
@worldspawn worldspawn force-pushed the possible-raw-path-fix branch from 0a083d6 to 11fc378 Compare January 4, 2024 05:00
@worldspawn
Copy link
Contributor Author

worldspawn commented Jan 4, 2024

I've tried this out (though my test was branched directly from v0.6.0) in our cluster using octopus deploy. It correctly served this path /api/Spaces-1/projects/Projects-45/refs%2fheads%2fdevelop/deploymentprocesses where the original v0.6.0 version of the interceptor would always return 404.

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for the fix! ❤️

@JorTurFer JorTurFer enabled auto-merge (squash) January 4, 2024 10:27
@JorTurFer JorTurFer merged commit 15718d1 into kedacore:main Jan 4, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants