Fix issue where external scaler gets wedged in a bad state when queue count metric fetch fails #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returning the error here cancels the whole queuePinger.start loop, causing the server to (theoretically) crash. Due to a separate bug, instead of crashing, the server can get wedged in an unhealthy state. Fixes kedacore#870. Signed-off-by: Andrew Garrett <andrewgarrett@google.com>
Signed-off-by: Andrew Garrett <andrewgarrett@google.com>
JorTurFer
approved these changes
Jan 15, 2024
JorTurFer
reviewed
Jan 15, 2024
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
JorTurFer
reviewed
Jan 15, 2024
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of returning an error when queue count fetch fails, only log an error and let the loop continue.
Checklist
README.mddocs/directoryFixes #870