From a135325b56d03617432cd0c7cd128e43dda17a15 Mon Sep 17 00:00:00 2001 From: Andrew Garrett Date: Wed, 10 Jan 2024 01:41:10 +0000 Subject: [PATCH 1/4] Queue Pinger: Don't return error if fetchAndSaveCounts fails. Returning the error here cancels the whole queuePinger.start loop, causing the server to (theoretically) crash. Due to a separate bug, instead of crashing, the server can get wedged in an unhealthy state. Fixes #870. Signed-off-by: Andrew Garrett --- scaler/queue_pinger.go | 1 - 1 file changed, 1 deletion(-) diff --git a/scaler/queue_pinger.go b/scaler/queue_pinger.go index 548c8dd8..670e7f47 100644 --- a/scaler/queue_pinger.go +++ b/scaler/queue_pinger.go @@ -99,7 +99,6 @@ func (q *queuePinger) start( err := q.fetchAndSaveCounts(ctx) if err != nil { lggr.Error(err, "getting request counts") - return fmt.Errorf("error getting request counts: %w", err) } // handle changes to the interceptor fleet // Endpoints From 40d6a51cc0c938cbbfefe6753b7afa8cd4e4f10e Mon Sep 17 00:00:00 2001 From: Andrew Garrett Date: Wed, 10 Jan 2024 20:29:07 +1100 Subject: [PATCH 2/4] Update CHANGELOG Signed-off-by: Andrew Garrett --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ccea6e6b..fe35e397 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -32,6 +32,7 @@ This changelog keeps track of work items that have been completed and are ready - **General**: Add new user agent probe ([#862](https://github.com/kedacore/http-add-on/issues/862)) - **General**: Increase ScaledObject polling interval to 15 seconds ([#799](https://github.com/kedacore/http-add-on/issues/799)) - **General**: Set forward request RawPath to original request RawPath ([#864](https://github.com/kedacore/http-add-on/issues/864)) +- **General**: Fix external scaler getting into bad state when retrieving queue lengths fails. ### Deprecations From 3a643f368943c3df76854c0d202a49a84d50dab4 Mon Sep 17 00:00:00 2001 From: Jorge Turrado Ferrero Date: Mon, 15 Jan 2024 08:54:41 +0100 Subject: [PATCH 3/4] Update CHANGELOG.md Signed-off-by: Jorge Turrado Ferrero --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index fe35e397..ced8bd24 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -31,8 +31,8 @@ This changelog keeps track of work items that have been completed and are ready - **General**: Add new user agent probe ([#862](https://github.com/kedacore/http-add-on/issues/862)) - **General**: Increase ScaledObject polling interval to 15 seconds ([#799](https://github.com/kedacore/http-add-on/issues/799)) +- **General**: Fix external scaler getting into bad state when retrieving queue lengths fails. ([#870](https://github.com/kedacore/http-add-on/issues/870)) - **General**: Set forward request RawPath to original request RawPath ([#864](https://github.com/kedacore/http-add-on/issues/864)) -- **General**: Fix external scaler getting into bad state when retrieving queue lengths fails. ### Deprecations From fec65afef0e10fb549d4fef8bd5b7294513453ad Mon Sep 17 00:00:00 2001 From: Jorge Turrado Ferrero Date: Mon, 15 Jan 2024 08:59:32 +0100 Subject: [PATCH 4/4] Update CHANGELOG.md Signed-off-by: Jorge Turrado Ferrero --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ced8bd24..c9682bb2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -30,8 +30,8 @@ This changelog keeps track of work items that have been completed and are ready ### Fixes - **General**: Add new user agent probe ([#862](https://github.com/kedacore/http-add-on/issues/862)) -- **General**: Increase ScaledObject polling interval to 15 seconds ([#799](https://github.com/kedacore/http-add-on/issues/799)) - **General**: Fix external scaler getting into bad state when retrieving queue lengths fails. ([#870](https://github.com/kedacore/http-add-on/issues/870)) +- **General**: Increase ScaledObject polling interval to 15 seconds ([#799](https://github.com/kedacore/http-add-on/issues/799)) - **General**: Set forward request RawPath to original request RawPath ([#864](https://github.com/kedacore/http-add-on/issues/864)) ### Deprecations