Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where external scaler gets wedged in a bad state when queue count metric fetch fails #876

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Fix issue where external scaler gets wedged in a bad state when queue count metric fetch fails #876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a135325
Queue Pinger: Don't return error if fetchAndSaveCounts fails.
werdnum Jan 10, 2024
40d6a51
Update CHANGELOG
werdnum Jan 10, 2024
3a643f3
Update CHANGELOG.md
JorTurFer Jan 15, 2024
fec65af
Update CHANGELOG.md
JorTurFer Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ This changelog keeps track of work items that have been completed and are ready
### Fixes

- **General**: Add new user agent probe ([#862](https://github.com/kedacore/http-add-on/issues/862))
- **General**: Fix external scaler getting into bad state when retrieving queue lengths fails. ([#870](https://github.com/kedacore/http-add-on/issues/870))
- **General**: Increase ScaledObject polling interval to 15 seconds ([#799](https://github.com/kedacore/http-add-on/issues/799))
- **General**: Set forward request RawPath to original request RawPath ([#864](https://github.com/kedacore/http-add-on/issues/864))

Expand Down
1 change: 0 additions & 1 deletion scaler/queue_pinger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ func (q *queuePinger) start(
err := q.fetchAndSaveCounts(ctx)
if err != nil {
lggr.Error(err, "getting request counts")
return fmt.Errorf("error getting request counts: %w", err)
}
// handle changes to the interceptor fleet
// Endpoints
Expand Down
Loading