feat: provide support to allow HTTP scaler to work alongside other core KEDA scalers #929
Conversation
|
Hey, mind sharing some samples on what that would look like? Is the problem that you'd otherwise have 2 scaledobjects or? |
|
@tomkerkhove Yeah the problem we have at the moment is that we already have a scaledobject with a kafka trigger added for scaling but we also have a requirement to add HTTP scaling to the same deployment so we can scale up on http requests also. This change will allow you to add skip annotation on the HTTPSO so you can add the external-push trigger to your existing scaledobject as an additional trigger etc. |
|
I like the solution but I'm worried about how this will scale in the future. Currently, we support |
|
There are also some static checks failures: https://github.com/kedacore/http-add-on/actions/runs/8230990823/job/22505562138?pr=929 |
devopsdynamo
force-pushed
the
main
branch
4 times, most recently
from
00ebf1b to
5020b67
Compare
|
We need to fix the DCO check too, you can check the steps just clicking the link: |
devopsdynamo
force-pushed
the
main
branch
2 times, most recently
from
0a783d7 to
a84c63f
Compare
|
There are also some linting errors, could you take a look? https://github.com/kedacore/http-add-on/actions/runs/8261625169/job/22724018316?pr=929 |
devopsdynamo
force-pushed
the
main
branch
2 times, most recently
from
278bbc0 to
b051c76
Compare
|
@tomkerkhove updated docs as per your suggestions, thanks. @JorTurFer lint errors should be fixed now also, my bad :) |
…re KEDA scalers Signed-off-by: Paul Cooke <Paul.Cooke@10xbanking.com>
Updated as requested |
This change provides support to allow HTTP scaler to work alongside other core KEDA scalers by allowing skipScaledObjectCreation annotation to be set on an HTTPScaledObject. This will ensure the reconciler to skip the KEDA core ScaledObjects creation which alllows you to create and manage your own ScaledObject with addtional triggers.
Checklist
README.mddocs/directoryFixes #