Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mysql scaler username from env #1419

Merged
merged 4 commits into from
Jul 22, 2024

Conversation

Indresh2410
Copy link
Contributor

@Indresh2410 Indresh2410 commented Jul 7, 2024

Provide a description of what has been changed
Adding documentation for usernameFromEnv support for MYSQL Scaler

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #5883

Signed-off-by: Indresh2410 <indreshprakash24@gmail.com>
Signed-off-by: Indresh2410 <indreshprakash24@gmail.com>
@Indresh2410 Indresh2410 requested a review from a team as a code owner July 7, 2024 13:23
Copy link

github-actions bot commented Jul 7, 2024

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Copy link

netlify bot commented Jul 7, 2024

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 16ebd49
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/669e519e3bfe65000882ab42
😎 Deploy Preview https://deploy-preview-1419--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Indresh2410 <indreshprakash24@gmail.com>
content/docs/2.0/scalers/mysql.md Outdated Show resolved Hide resolved
Signed-off-by: Indresh2410 <indreshprakash24@gmail.com>
@Indresh2410 Indresh2410 requested a review from JorTurFer July 22, 2024 12:34
@JorTurFer
Copy link
Member

Thanks a lot! ❤️

@JorTurFer JorTurFer merged commit 32351ed into kedacore:main Jul 22, 2024
7 checks passed
shubhusion pushed a commit to shubhusion/keda-docs that referenced this pull request Aug 5, 2024
* Add usernameFromEnv support for MYSQL Scaler

Signed-off-by: Indresh2410 <indreshprakash24@gmail.com>

* Fix typo

Signed-off-by: Indresh2410 <indreshprakash24@gmail.com>

* Update Readme

Signed-off-by: Indresh2410 <indreshprakash24@gmail.com>

* Move readme to different folder

Signed-off-by: Indresh2410 <indreshprakash24@gmail.com>

---------

Signed-off-by: Indresh2410 <indreshprakash24@gmail.com>
Signed-off-by: shubhusion <shubham27.sharma03@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants