diff --git a/CHANGELOG.md b/CHANGELOG.md index 017de52bb68..a17c5497d04 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -44,7 +44,7 @@ To learn more about active deprecations, we recommend checking [GitHub Discussio ### Breaking Changes -- **Kafka Scaler**: move `tls` and `sasl` in TriggerAuthentication to `enableTls` and `saslAuthType` in ScaledObject ([#4232](https://github.com/kedacore/keda/issues/4322)) +- TODO ### New @@ -71,6 +71,7 @@ Here is an overview of all new **experimental** features: - **Azure Pipelines Scaler**: New configuration parameter `requireAllDemands` to scale only if jobs request all demands provided by the scaling definition ([#4138](https://github.com/kedacore/keda/issues/4138)) - **Hashicorp Vault**: Add support to secrets backend version 1 ([#2645](https://github.com/kedacore/keda/issues/2645)) - **Kafka Scaler**: Improve error logging for `GetBlock` method ([#4232](https://github.com/kedacore/keda/issues/4232)) +- **Kafka Scaler**: Add support to use `enableTls` and `saslAuthType` in ScaledObject ([#4232](https://github.com/kedacore/keda/issues/4322)) - **Prometheus Scaler**: Add custom headers and custom auth support ([#4208](https://github.com/kedacore/keda/issues/4208)) - **RabbitMQ Scaler**: Add TLS support ([#967](https://github.com/kedacore/keda/issues/967)) - **Redis Scalers**: Add support to Redis 7 ([#4052](https://github.com/kedacore/keda/issues/4052)) diff --git a/pkg/scalers/kafka_scaler.go b/pkg/scalers/kafka_scaler.go index 130b77bc14e..4f2accea823 100644 --- a/pkg/scalers/kafka_scaler.go +++ b/pkg/scalers/kafka_scaler.go @@ -119,7 +119,7 @@ func NewKafkaScaler(config *ScalerConfig) (Scaler, error) { }, nil } -func parseKafkaAuthParams(config *ScalerConfig, meta *kafkaMetadata, logger logr.Logger) error { +func parseKafkaAuthParams(config *ScalerConfig, meta *kafkaMetadata) error { meta.saslType = KafkaSASLTypeNone var saslAuthType string switch { @@ -295,7 +295,7 @@ func parseKafkaMetadata(config *ScalerConfig, logger logr.Logger) (kafkaMetadata meta.activationLagThreshold = t } - if err := parseKafkaAuthParams(config, &meta, logger); err != nil { + if err := parseKafkaAuthParams(config, &meta); err != nil { return meta, err }