From 74b88dcd5fce82eb831b06ef7fae0dae9d147f3c Mon Sep 17 00:00:00 2001 From: Kun Woo Yoo Date: Wed, 18 Sep 2024 20:57:16 +0900 Subject: [PATCH] modify CHANGELOG Signed-off-by: Kun Woo Yoo --- CHANGELOG.md | 2 +- pkg/scalers/cpu_memory_scaler_test.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ae977f01872..0f02f924d07 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -74,7 +74,7 @@ Here is an overview of all new **experimental** features: - **GitHub Scaler**: Fixed pagination, fetching repository list ([#5738](https://github.com/kedacore/keda/issues/5738)) - **Kafka**: Fix logic to scale to zero on invalid offset even with earliest offsetResetPolicy ([#5689](https://github.com/kedacore/keda/issues/5689)) - **RabbitMQ Scaler**: Add connection name for AMQP ([#5958](https://github.com/kedacore/keda/issues/5958)) -- TODO ([#XXX](https://github.com/kedacore/keda/issues/XXX)) +- **CPU/Memory Scaler**: Add activation feature ([#6057](https://github.com/kedacore/keda/issues/6057)) ### Fixes diff --git a/pkg/scalers/cpu_memory_scaler_test.go b/pkg/scalers/cpu_memory_scaler_test.go index d0fdc817499..90cf5af6d1e 100644 --- a/pkg/scalers/cpu_memory_scaler_test.go +++ b/pkg/scalers/cpu_memory_scaler_test.go @@ -162,7 +162,7 @@ func TestGetMetricsAndActivity_IsActive(t *testing.T) { kubeClient := fake.NewClientBuilder().WithRuntimeObjects(createHPAWithAverageUtilization(50), createScaledObject()).Build() scaler, _ := NewCPUMemoryScaler(v1.ResourceCPU, config, kubeClient) - _, isActive, _ := scaler.GetMetricsAndActivity(context.TODO(), "cpu") + _, isActive, _ := scaler.GetMetricsAndActivity(context.Background(), "cpu") assert.Equal(t, isActive, true) } @@ -176,6 +176,6 @@ func TestGetMetricsAndActivity_IsNotActive(t *testing.T) { kubeClient := fake.NewClientBuilder().WithRuntimeObjects(createHPAWithAverageUtilization(30), createScaledObject()).Build() scaler, _ := NewCPUMemoryScaler(v1.ResourceCPU, config, kubeClient) - _, isActive, _ := scaler.GetMetricsAndActivity(context.TODO(), "cpu") + _, isActive, _ := scaler.GetMetricsAndActivity(context.Background(), "cpu") assert.Equal(t, isActive, false) }