From 6011c8ad2bd8187be9efb347c6576c7d7b9a6d08 Mon Sep 17 00:00:00 2001 From: yusank Date: Mon, 27 Dec 2021 18:00:35 +0800 Subject: [PATCH 1/2] fix: wrong calculation of retry backoff duraion Signed-off-by: yusank --- pkg/scalers/external_scaler.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/scalers/external_scaler.go b/pkg/scalers/external_scaler.go index 6a7f8693b41..3e3fe0b871a 100644 --- a/pkg/scalers/external_scaler.go +++ b/pkg/scalers/external_scaler.go @@ -236,7 +236,7 @@ func (s *externalPushScaler) Run(ctx context.Context, active chan<- bool) { // timer, to release background resources. retryBackoff := func() *time.Timer { tmr := time.NewTimer(retryDuration) - retryDuration *= time.Second * 2 + retryDuration *= 2 if retryDuration > time.Minute*1 { retryDuration = time.Minute * 1 } From 1bbb9b356f423b70f8bf95151e1892bd697a10d4 Mon Sep 17 00:00:00 2001 From: yusank Date: Tue, 4 Jan 2022 15:38:48 +0800 Subject: [PATCH 2/2] docs(CHANGELOG): update improvements section Signed-off-by: yusank --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7abb63990ee..f56f78dc651 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -36,6 +36,7 @@ - PostgreSQL Scaler: Assign PostgreSQL `userName` to correct attribute ([#2432](https://github.com/kedacore/keda/pull/2432)) - Kafka Scaler: concurrently query brokers for consumer and producer offsets ([#2405](https://github.com/kedacore/keda/pull/2405)) - Delete the cache entry when a ScaledObject is deleted ([#2408](https://github.com/kedacore/keda/pull/2408)) +- External Scaler: fix wrong calculation of retry backoff duration ([#2416](https://github.com/kedacore/keda/pull/2416)) ### Breaking Changes