-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix --tools=all
not working properly
#3361
Merged
Merged
Changes from 11 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
5faebf3
add fix
SajidAlamQB 0f61dd5
Merge branch 'develop' into bugfix/addons=all-fix
lrcouto 7e7ca3f
add fix
SajidAlamQB 16ef432
Rename addons to tools (#3357)
AhdraMeraliQB 87e2e1e
Fix broken tests (#3366)
AhdraMeraliQB 9ab8759
Merge branch 'develop' into bugfix/addons=all-fix
lrcouto f127b48
Fix variable names on _convert_tool_names_to_numbers
lrcouto 4090586
Merge branch 'bugfix/addons=all-fix' of github.com:kedro-org/kedro in…
lrcouto 47c4118
Merge branch 'bugfix/addons=all-fix' of https://github.com/kedro-org/…
SajidAlamQB 70985cc
Merge branch 'develop' into bugfix/addons=all-fix
SajidAlamQB a3eea61
Merge branch 'develop' into bugfix/addons=all-fix
SajidAlamQB fd7b734
Merge branch 'develop' into bugfix/addons=all-fix
lrcouto 6888463
Merge branch 'develop' into bugfix/addons=all-fix
lrcouto 143b204
Merge branch 'develop' into bugfix/addons=all-fix
lrcouto ba0d696
Add tests for helper functions
lrcouto dab4d29
Merge branch 'develop' into bugfix/addons=all-fix
SajidAlamQB d6672a3
Merge branch 'develop' into bugfix/addons=all-fix
lrcouto f9802c7
Merge branch 'develop' into bugfix/addons=all-fix
lrcouto b353f63
Merge branch 'develop' into bugfix/addons=all-fix
lrcouto 545755a
Lint
lrcouto 4bc1748
Merge branch 'develop' into bugfix/addons=all-fix
lrcouto 93d5b50
Merge branch 'develop' into bugfix/addons=all-fix
lrcouto c875b3c
Merge branch 'develop' into bugfix/addons=all-fix
lrcouto 3df74ab
Return numbers to tools names on conversion from all
lrcouto a821ede
Merge branch 'bugfix/addons=all-fix' of github.com:kedro-org/kedro in…
lrcouto d33b745
Merge branch 'develop' into bugfix/addons=all-fix
lrcouto a228843
Merge branch 'develop' into bugfix/addons=all-fix
SajidAlamQB 31d7a3f
Merge branch 'develop' into bugfix/addons=all-fix
SajidAlamQB 3e6666e
Merge branch 'develop' into bugfix/addons=all-fix
SajidAlamQB File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we just need to update the TOOLS_SHORTNAME_TO_NUMBER dictionary? Put "none" and "all" there? Or it will break something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking this as well but it feels a bit weird as "all" and "none" aren't tools.