Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded filepath check on dataset factories #3561

Merged
merged 7 commits into from
Feb 2, 2024
Merged

Remove unneeded filepath check on dataset factories #3561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bf741b7
Adding a list of "path" keys to check dataset config against.
MosaicMan Jan 27, 2024
0e96ad8
Clean up `catalog resolve` CLI command to remove unnecessary checks.
MosaicMan Jan 31, 2024
9fde1e2
Merge branch 'main' into cli_catalog_resolve_patterns
ankatiyar Feb 1, 2024
fc3bca6
Update release notes
ankatiyar Feb 1, 2024
d5e6ae6
Merge branch 'main' into cli_catalog_resolve_patterns
ankatiyar Feb 1, 2024
b6e60cf
Merge branch 'main' into cli_catalog_resolve_patterns
AhdraMeraliQB Feb 1, 2024
16883e9
Merge branch 'main' into cli_catalog_resolve_patterns
ankatiyar Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Major features and improvements

## Bug fixes and other changes
* Updated CLI Command `kedro catalog resolve` to work with dataset factories that use `PartitionedDataset`.
* Addressed arbitrary file write via archive extraction security vulnerability in micropackaging.
* Added the `_EPHEMERAL` attribute to `AbstractDataset` and other Dataset classes that inherit from it.

Expand All @@ -11,6 +12,9 @@
## Documentation changes

## Community contributions
Many thanks to the following Kedroids for contributing PRs to this release:

Check warning on line 15 in RELEASE.md

View workflow job for this annotation

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Kedro.weaselwords] 'Many' is a weasel word!

Raw Output:
{"message": "[Kedro.weaselwords] 'Many' is a weasel word!", "location": {"path": "RELEASE.md", "range": {"start": {"line": 15, "column": 1}}}, "severity": "WARNING"}

Check warning on line 15 in RELEASE.md

View workflow job for this annotation

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Kedro.Spellings] Did you really mean 'Kedroids'?

Raw Output:
{"message": "[Kedro.Spellings] Did you really mean 'Kedroids'?", "location": {"path": "RELEASE.md", "range": {"start": {"line": 15, "column": 30}}}, "severity": "WARNING"}
* [MosaicMan](https://github.com/MosaicMan)


# Release 0.19.2

Expand Down
7 changes: 0 additions & 7 deletions kedro/framework/cli/catalog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,13 +265,6 @@ def resolve_patterns(metadata: ProjectMetadata, env: str) -> None:
ds_name, matched_pattern, ds_config_copy
)

ds_config["filepath"] = _trim_filepath(
str(context.project_path) + "/", ds_config["filepath"]
)
explicit_datasets[ds_name] = ds_config

secho(yaml.dump(explicit_datasets))


def _trim_filepath(project_path: str, file_path: str) -> str:
return file_path.replace(project_path, "", 1)
Loading