Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use range in the t-network solidity-contracts dependency #2986

Merged
merged 1 commit into from
May 12, 2022

Conversation

pdyraga
Copy link
Member

@pdyraga pdyraga commented May 12, 2022

We tried using development tag to always point to the latest
development package, but that was causing An unexpected error
occurred: "expected manifest". error when running yarn upgrade
@threshold-network/solidity-contracts. So we're going back to using the
version range. We may use development tag in the future, once we
figure out the reason behind the error that we were getting.

It is possible that the error was related to this issue:
yarnpkg/yarn#4731

See #2985 for ECDSA part.

We tried using development tag to always point to the latest
development package, but that was causing An unexpected error
occurred: "expected manifest". error when running yarn upgrade
`@threshold-network/solidity-contracts`. So we're going back to using the
version range. We may use development tag in the future, once we
figure out the reason behind the error that we were getting.

It is possible that the error was related to this issue:
yarnpkg/yarn#4731
@michalinacienciala michalinacienciala merged commit b066eb7 into main May 12, 2022
@michalinacienciala michalinacienciala deleted the no-tag-for-deps branch May 12, 2022 16:50
@pdyraga pdyraga added this to the solidity/v2.0.0 milestone Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants