Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeepassXC uses the application icon for the tray with Numix icon theme #1840

Closed
sojusnik opened this issue Apr 12, 2018 · 12 comments
Closed

Comments

@sojusnik
Copy link

sojusnik commented Apr 12, 2018

Expected Behavior

Even if the Numix icon theme is installed, the tray icon should use the specific icons, not the application one, as described here.

Current Behavior

If the Numix icon theme is used under Ubuntu 17.10, then the Keepassxc tray icon always looks like the app icon, as described here.

Debug Info

KeePassXC - Version 2.3.1
Revision: 2fcaeea

Bibliotheken:

  • Qt 5.9.1
  • libgcrypt 1.7.8

Betriebssystem: Ubuntu 17.10
CPU-Architektur: x86_64
Kernel: linux 4.13.0-38-generic

Aktivierte Erweiterungen:

  • Auto-Type
  • Browser Integration
  • Legacy Browser Integration (KeePassHTTP)
  • SSH Agent
  • YubiKey
@droidmonkey
Copy link
Member

What is meant by specific icons?

@sojusnik
Copy link
Author

By "specific icons" I mean those icons that are specifically designed for the system tray, as shown here.

@TheZ3ro
Copy link
Contributor

TheZ3ro commented Apr 12, 2018

Ok so if I understand this correctly the problem is that KeePassXC uses the same name for the app icon and for the icon in the tray. (like stated in bilelmoussaoui/Hardcode-Tray#173 (comment) and "upstream" bug report for KeePassX https://dev.keepassx.org/issues/527)

Am I right?

@sojusnik
Copy link
Author

@TheZ3ro You seem to be right.

@TheZ3ro TheZ3ro added this to the v2.4.0 milestone Apr 18, 2018
@TheZ3ro
Copy link
Contributor

TheZ3ro commented Apr 18, 2018

@sojusnik Ok seems doable

@droidmonkey droidmonkey modified the milestones: v2.4.0, v2.5.0 Jan 16, 2019
@Veazer
Copy link

Veazer commented Apr 19, 2019

@TheZ3ro I've done some icon creation and I would be willing to create them. Unfortunately I have zero experience with git, but I can hand them off to someone else or whatever you suggest.

@phoerious phoerious removed this from the v2.5.0 milestone Oct 26, 2019
@Stunkymonkey
Copy link

since it got removed from last release: are there any plans to fix this?

@droidmonkey
Copy link
Member

We are no longer allowing themes to change our icons, so yes the next release standardizes behavior across all platforms.

@Stunkymonkey
Copy link

so this means icon-themes (e.g. numix) will not be able to change the icon right?

@droidmonkey
Copy link
Member

That is correct.

@mrmeszaros
Copy link

@droidmonkey could You please give a reasoning why icon theming will be dropped?
Just to clarify for me and those to come in the future.

@droidmonkey
Copy link
Member

Standardizes the look and feel of our application across platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants