New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies for CITS ERMS #302

Merged

hmiguim merged 1 commit into development from cafonso-devERMS

Nov 29, 2024

Contributor

carlosjepard commented Nov 28, 2024

No description provided.

carlosjepard requested a review from hmiguim

November 28, 2024 12:07

carlosjepard assigned hmiguim

github-actions bot reviewed

View reviewed changes

github-actions bot left a comment

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

checkstyle

src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java|239 col 17| Variable 'representationMETSWrapper' should be declared final.
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java|239 col 44| Parameter representation should be final.
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java|239 col 61| Variable 'representation' should be declared final.
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java|239 col 77| Parameter representationId should be final.
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java|239 col 84| Variable 'representationId' should be declared final.
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java|253 col 20| Variable 'fileType' should be declared final.
src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java|259 col 61| Unnecessary parentheses around expression.
src/main/java/org/roda_project/commons_ip2/model/IPContentInformationType.java|18 col 5| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentInformationType.java|18 col 11| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentInformationType.java|18 col 26| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentInformationType.java|18 col 34| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentInformationType.java|18 col 42| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentInformationType.java|18 col 51| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentInformationType.java|18 col 60| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentInformationType.java|18 col 67| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentInformationType.java|18 col 74| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentType.java|29| Line is longer than 120 characters (found 127).
src/main/java/org/roda_project/commons_ip2/model/IPContentType.java|29 col 5| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentType.java|29 col 27| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentType.java|29 col 49| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentType.java|29 col 69| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip2/model/IPContentType.java|29 col 105| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip/utils/IPEnums.java|36 col 5| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip/utils/IPEnums.java|36 col 13| Missing a Javadoc comment.
src/main/java/org/roda_project/commons_ip/utils/IPEnums.java|36 col 20| Missing a Javadoc comment.

src/main/java/org/roda_project/commons_ip2/validator/common/FolderManager.java

                   return new FileInputStream(metsPath);
                 }
+                public InputStream getErmsInputStream(final Path path) throws FileNotFoundException {

github-actions bot Nov 28, 2024

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

src/main/java/org/roda_project/commons_ip2/validator/common/FolderManager.java

+                    }
+                  }
+                  if (ermsPath == null) {
+                    LOGGER.debug("ERMS.xml not Found");

github-actions bot Nov 28, 2024

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.MultipleStringLiteralsCheck> _{reported by reviewdog 🐶}
The String "ERMS.xml not Found" appears 2 times in the file.

src/main/java/org/roda_project/commons_ip2/validator/common/ZipManager.java

+                 * @throws IOException
+                 *           if some I/O error occurs
+                 */
+                public InputStream getErmsInputStream(Path path) throws IOException {

github-actions bot Nov 28, 2024

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck> _{reported by reviewdog 🐶}
Parameter path should be final.

src/main/java/org/roda_project/commons_ip2/validator/common/ZipManager.java

+                 * @throws IOException
+                 *           if some I/O error occurs
+                 */
+                public InputStream getErmsInputStream(Path path) throws IOException {

github-actions bot Nov 28, 2024

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'path' should be declared final.

src/main/java/org/roda_project/commons_ip2/validator/common/ZipManager.java

+                    zipFile = new ZipFile(path.toFile());
+                  }
+                  Enumeration entries = zipFile.entries();

github-actions bot Nov 28, 2024

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'entries' should be declared final.

src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java


		}

		private void addRepresentationDataFilesToZipErmsAndMETS(IPInterface ip, Map<String, ZipEntryInfo> zipEntries,

github-actions bot Nov 28, 2024

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck> _{reported by reviewdog 🐶}
Parameter ip should be final.

src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java


		}

		private void addRepresentationDataFilesToZipErmsAndMETS(IPInterface ip, Map<String, ZipEntryInfo> zipEntries,

github-actions bot Nov 28, 2024

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'ip' should be declared final.

src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java


		}

		private void addRepresentationDataFilesToZipErmsAndMETS(IPInterface ip, Map<String, ZipEntryInfo> zipEntries,

github-actions bot Nov 28, 2024

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck> _{reported by reviewdog 🐶}
Parameter zipEntries should be final.

src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java


		}

		private void addRepresentationDataFilesToZipErmsAndMETS(IPInterface ip, Map<String, ZipEntryInfo> zipEntries,

github-actions bot Nov 28, 2024

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'zipEntries' should be declared final.

src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java

+                }
+                private void addRepresentationDataFilesToZipErmsAndMETS(IPInterface ip, Map<String, ZipEntryInfo> zipEntries,
+                  MetsWrapper representationMETSWrapper, IPRepresentation representation, String representationId)

github-actions bot Nov 28, 2024

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck> _{reported by reviewdog 🐶}
Parameter representationMETSWrapper should be final.

carlosjepard force-pushed the cafonso-devERMS branch from 1d06e48 to 8b757cb Compare

November 28, 2024 13:28

github-actions bot reviewed

View reviewed changes

src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java

+                }
+                private void addRepresentationDataFilesToZipErmsAndMETS(IPInterface ip, Map<String, ZipEntryInfo> zipEntries,
+                  MetsWrapper representationMETSWrapper, IPRepresentation representation, String representationId)

github-actions bot Nov 28, 2024

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'representationMETSWrapper' should be declared final.

src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java

+                }
+                private void addRepresentationDataFilesToZipErmsAndMETS(IPInterface ip, Map<String, ZipEntryInfo> zipEntries,
+                  MetsWrapper representationMETSWrapper, IPRepresentation representation, String representationId)

github-actions bot Nov 28, 2024

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck> _{reported by reviewdog 🐶}
Parameter representation should be final.

src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java

+                }
+                private void addRepresentationDataFilesToZipErmsAndMETS(IPInterface ip, Map<String, ZipEntryInfo> zipEntries,
+                  MetsWrapper representationMETSWrapper, IPRepresentation representation, String representationId)

github-actions bot Nov 28, 2024

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'representation' should be declared final.

src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java

+                }
+                private void addRepresentationDataFilesToZipErmsAndMETS(IPInterface ip, Map<String, ZipEntryInfo> zipEntries,
+                  MetsWrapper representationMETSWrapper, IPRepresentation representation, String representationId)

github-actions bot Nov 28, 2024

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck> _{reported by reviewdog 🐶}
Parameter representationId should be final.

src/main/java/org/roda_project/commons_ip2/model/impl/eark/EARKUtils.java

+                }
+                private void addRepresentationDataFilesToZipErmsAndMETS(IPInterface ip, Map<String, ZipEntryInfo> zipEntries,
+                  MetsWrapper representationMETSWrapper, IPRepresentation representation, String representationId)

github-actions bot Nov 28, 2024

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.coding.FinalLocalVariableCheck> _{reported by reviewdog 🐶}
Variable 'representationId' should be declared final.

src/main/java/org/roda_project/commons_ip2/model/IPContentType.java

@@ @@ -26,7 +26,7 @@ public enum IPContentTypeEnum { @@
                   AUDIO_ON_TANGIBLE_MEDIUM("Audio – On Tangible Medium (digital or analog)"),
                   AUDIO_MEDIA_INDEPENDENT("Audio – Media-independent (digital)"),
                   MOTION_PICTURES("Motion Pictures – Digital and Physical Media"), VIDEO("Video – File-based and Physical Media"),
-                  SOFTWARE("Software"), DATASETS("Datasets"), GEOSPATIAL_DATA("Geospatial Data"), DATABASES("Databases"),
+                  SOFTWARE("Software"), DATASETS("Datasets"), DATASET("Dataset"), GEOSPATIAL_DATA("Geospatial Data"), DATABASES("Databases"),

github-actions bot Nov 28, 2024

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

src/main/java/org/roda_project/commons_ip2/model/IPContentType.java

@@ @@ -26,7 +26,7 @@ public enum IPContentTypeEnum { @@
                   AUDIO_ON_TANGIBLE_MEDIUM("Audio – On Tangible Medium (digital or analog)"),
                   AUDIO_MEDIA_INDEPENDENT("Audio – Media-independent (digital)"),
                   MOTION_PICTURES("Motion Pictures – Digital and Physical Media"), VIDEO("Video – File-based and Physical Media"),
-                  SOFTWARE("Software"), DATASETS("Datasets"), GEOSPATIAL_DATA("Geospatial Data"), DATABASES("Databases"),
+                  SOFTWARE("Software"), DATASETS("Datasets"), DATASET("Dataset"), GEOSPATIAL_DATA("Geospatial Data"), DATABASES("Databases"),

github-actions bot Nov 28, 2024

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

src/main/java/org/roda_project/commons_ip/utils/IPEnums.java

@@ @@ -33,7 +33,7 @@ public static IPStatus parse(String value) { @@
                 }
                 public enum SipType {
-                  EARK2S, EARK2
+                  EARK2S, EARK2, ERMS

github-actions bot Nov 28, 2024

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

src/main/java/org/roda_project/commons_ip/utils/IPEnums.java

@@ @@ -33,7 +33,7 @@ public static IPStatus parse(String value) { @@
                 }
                 public enum SipType {
-                  EARK2S, EARK2
+                  EARK2S, EARK2, ERMS

github-actions bot Nov 28, 2024

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

src/main/java/org/roda_project/commons_ip/utils/IPEnums.java

@@ @@ -33,7 +33,7 @@ public static IPStatus parse(String value) { @@
                 }
                 public enum SipType {
-                  EARK2S, EARK2
+                  EARK2S, EARK2, ERMS

github-actions bot Nov 28, 2024

⚠️ [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.


          Dependencies for CITS ERMS

9a28fc6

carlosjepard force-pushed the cafonso-devERMS branch from 8b757cb to 9a28fc6 Compare

November 28, 2024 15:46

hmiguim merged commit d4df5d0 into development

3 checks passed

hmiguim deleted the cafonso-devERMS branch

November 29, 2024 10:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet