fix: detect multiple zeros as an invalid step (#743) [skip ci]

kelektiv · Oct 25, 2023 · b0bf677 · b0bf677
1 parent 5ff1cf8
commit b0bf677
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/time.ts b/src/time.ts
@@ -774,10 +774,10 @@ export class CronTime {
 				let upper = mUpper !== undefined ? parseInt(mUpper, 10) : undefined;
 
 				const wasStepDefined = mStep !== undefined;
-				if (mStep === '0') {
+				const step = parseInt(mStep ?? '1', 10);
+				if (step === 0) {
 					throw new Error(`Field (${unit}) has a step of zero`);
 				}
-				const step = parseInt(mStep ?? '1', 10);
 
 				if (upper !== undefined && lower > upper) {
 					throw new Error(`Field (${unit}) has an invalid range`);

diff --git a/tests/crontime.test.ts b/tests/crontime.test.ts
@@ -210,9 +210,17 @@ describe('crontime', () => {
 	});
 
 	it('should test invalid step', () => {
+		expect(() => {
+			new CronTime('* * * 1/ *');
+		}).toThrow();
+
 		expect(() => {
 			new CronTime('* * * 1/0 *');
 		}).toThrow();
+
+		expect(() => {
+			new CronTime('* * * 1/00 *');
+		}).toThrow();
 	});
 
 	it('should test invalid range', () => {