-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not compatible with latest versions of Svelte #234
Comments
This was referenced Sep 11, 2022
Merged
@davipon and @ivanhofer, I just sent #235 to upgrade this library to the latest version of Svelte and all the tests are passing. Perhaps there's something more that's needed to reproduce the issue? |
Published as svelte-htm@1.2.0 — Didn't have the time to fix the CI. Locally it worked. |
Thanks again @benmccann for the time you took to update all the dependencies. |
Afraid this is occurring again:
package.json "type": "module",
"devDependencies": {
"@playwright/test": "~1.31.1",
"@sveltejs/adapter-auto": "~2.0.0",
"@sveltejs/kit": "~1.9.2",
"@testing-library/jest-dom": "~5.16.5",
"@testing-library/svelte": "~3.2.2",
"@typescript-eslint/eslint-plugin": "~5.53.0",
"@typescript-eslint/parser": "~5.53.0",
"eslint": "~8.35.0",
"eslint-plugin-jest-dom": "~4.0.3",
"eslint-plugin-svelte3": "~4.0.0",
"jsdom": "~21.1.0",
"postcss": "~8.4.21",
"postcss-load-config": "~4.0.1",
"sass": "~1.58.3",
"svelte": "~3.55.0",
"svelte-check": "~3.0.1",
"svelte-htm": "~1.2.0",
"svelte-preprocess": "~5.0.1",
"tslib": "~2.5.0",
"typescript": "~4.9.3",
"vite": "~4.1.4",
"vitest": "~0.25.3"
},
"dependencies": {
"svelte-material-icons": "~3.0.4"
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@davipon and @ivanhofer reported that using this library with recent versions gives the error:
I see this library uses
svelte-fragment-component
andsvelte-hyperscript
. From a quick glance at the code,svelte-hyperscript
appears to be bundlingsvelte
, which it shouldn't be doing. Probably if that library movedsvelte
fromdevDependencies
todependencies
orpeerDependencies
it would work because its Rollup config treatsdependencies
asexternal
.I filed the issue here rather than in
svelte-hyperscript
because it would be good to confirm that it fixes the issue here by bumping the Svelte version used for testing in this repo.The text was updated successfully, but these errors were encountered: