[fix] Prevent the app from crashing on geojson layer hover (#2087)

keplergl · Jan 18, 2023 · fd3a7a8 · fd3a7a8
1 parent a66f98f
commit fd3a7a8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/layers/src/geojson-layer/geojson-layer.ts b/src/layers/src/geojson-layer/geojson-layer.ts
@@ -322,7 +322,11 @@ export default class GeoJsonLayer extends Layer {
 
   getHoverData(object, dataContainer) {
     // index of dataContainer is saved to feature.properties
-    return dataContainer.row(object.properties.index);
+    const index = object?.properties?.index;
+    if (index >= 0) {
+      return dataContainer.row(index);
+    }
+    return null;
   }
 
   calculateDataAttribute({dataContainer, filteredIndex}, getPosition) {

diff --git a/src/reducers/src/layer-utils.ts b/src/reducers/src/layer-utils.ts
@@ -152,6 +152,9 @@ export function getLayerHoverProp({
       }
       const {dataContainer, fields} = datasets[dataId];
       const data: DataRow | null = layer.getHoverData(object, dataContainer, fields);
+      if (!data) {
+        return null;
+      }
       const fieldsToShow = interactionConfig.tooltip.config.fieldsToShow[dataId];
 
       return {