From 5194af01076c3246e8d61f2a75d2ff5eaf32e93b Mon Sep 17 00:00:00 2001 From: slayerjain Date: Thu, 27 Oct 2022 14:26:11 +0530 Subject: [PATCH] fix: remove defered resp closer from for loop Signed-off-by: slayerjain --- keploy/keploy.go | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/keploy/keploy.go b/keploy/keploy.go index df0a1fdc..db39451d 100644 --- a/keploy/keploy.go +++ b/keploy/keploy.go @@ -616,8 +616,6 @@ func (k *Keploy) fetch() []models.TestCase { k.Log.Error("failed to fetch testcases from keploy cloud", zap.Error(errors.New("failed to send get request: "+resp.Status))) return nil } - - defer resp.Body.Close() body, err := ioutil.ReadAll(resp.Body) if err != nil { k.Log.Error("failed to fetch testcases from keploy cloud", zap.Error(err)) @@ -631,13 +629,18 @@ func (k *Keploy) fetch() []models.TestCase { return nil } tcs = append(tcs, res...) - if len(res) < pageSize { - break - } eof := resp.Header.Get("EOF") + err = resp.Body.Close() + if err != nil { + k.Log.Error("failed to close keploy resp while fetching testcases from keploy", zap.Error(err)) + } if eof == "true" { break } + + if len(res) < pageSize { + break + } } return tcs }