This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
fix: Fix event handling for duplicated subscriptions in go-sdk remote execution plane use case
#542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: warber <bernd.warmuth@dynatrace.com>
Signed-off-by: warber <bernd.warmuth@dynatrace.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| }, | ||
| } | ||
| ctx, cancel := context.WithCancel(context.TODO()) | ||
| go controlPlane.Register(ctx, integration) |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Error return value of controlPlane.Register is not checked (errcheck)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #542 +/- ##
=========================================
Coverage ? 50.87%
=========================================
Files ? 105
Lines ? 5844
Branches ? 0
=========================================
Hits ? 2973
Misses ? 2737
Partials ? 134 |
warber
changed the title
go-sdk remote execution plane use casego-sdk remote execution plane use case
bacherfl
reviewed
Sep 27, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
bacherfl
approved these changes
Oct 5, 2022
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes keptn/keptn#8875
Additionally, this PR contains logging improvements of the go-sdk, meaning that it will output a log message containing the currently subscribed events. at INFO level only if the current subscriptions have been changed.