Skip to content

Commit dab2342

Browse files
mpekuba-moo
authored andcommitted
net: ucc_geth: Drop extraneous parentheses in comparison
Clang warns about the extra parentheses in this comparison: drivers/net/ethernet/freescale/ucc_geth.c:1361:28: warning: equality comparison with extraneous parentheses if ((ugeth->phy_interface == PHY_INTERFACE_MODE_SGMII)) ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ It seems clear the intent here is to do a comparison not an assignment, so drop the extra parentheses to avoid any confusion. Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://lore.kernel.org/r/20201023033236.3296988-1-mpe@ellerman.id.au Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 0c3b7f4 commit dab2342

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ethernet/freescale/ucc_geth.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1358,7 +1358,7 @@ static int adjust_enet_interface(struct ucc_geth_private *ugeth)
13581358
(ugeth->phy_interface == PHY_INTERFACE_MODE_RTBI)) {
13591359
upsmr |= UCC_GETH_UPSMR_TBIM;
13601360
}
1361-
if ((ugeth->phy_interface == PHY_INTERFACE_MODE_SGMII))
1361+
if (ugeth->phy_interface == PHY_INTERFACE_MODE_SGMII)
13621362
upsmr |= UCC_GETH_UPSMR_SGMM;
13631363

13641364
out_be32(&uf_regs->upsmr, upsmr);

0 commit comments

Comments
 (0)