Skip to content

Conversation

@kernel-patches-bot
Copy link

Pull request for series with
subject: Allow attaching to bare tracepoints
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=416125

@kernel-patches-bot
Copy link
Author

Master branch: 232164e
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=416125
version: 2

@kernel-patches-bot
Copy link
Author

Master branch: a2c2998
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=416125
version: 2

@kernel-patches-bot
Copy link
Author

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=416125 expired. Closing PR.

@kernel-patches-bot
Copy link
Author

Master branch: 95204c9
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=417431
version: 3

@kernel-patches-bot
Copy link
Author

Master branch: 95204c9
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=417431
version: 3

kernel-patches-bot and others added 3 commits January 19, 2021 13:04
Some subsystems only have bare tracepoints (a tracepoint with no
associated trace event) to avoid the problem of trace events being an
ABI that can't be changed.

From bpf presepective, bare tracepoints are what it calls
RAW_TRACEPOINT().

Since bpf assumed there's 1:1 mapping, it relied on hooking to
DEFINE_EVENT() macro to create bpf mapping of the tracepoints. Since
bare tracepoints use DECLARE_TRACE() to create the tracepoint, bpf had
no knowledge about their existence.

By teaching bpf_probe.h to parse DECLARE_TRACE() in a similar fashion to
DEFINE_EVENT(), bpf can find and attach to the new raw tracepoints.

Enabling that comes with the contract that changes to raw tracepoints
don't constitute a regression if they break existing bpf programs.
We need the ability to continue to morph and modify these raw
tracepoints without worrying about any ABI.

Update Documentation/bpf/bpf_design_QA.rst to document this contract.

Acked-by: Yonghong Song <yhs@fb.com>
Signed-off-by: Qais Yousef <qais.yousef@arm.com>
Reuse module_attach infrastructure to add a new bare tracepoint to check
we can attach to it as a raw tracepoint.

Signed-off-by: Qais Yousef <qais.yousef@arm.com>
Acked-by: Yonghong Song <yhs@fb.com>
@kernel-patches-bot
Copy link
Author

Master branch: 3a6984e
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=417431
version: 3

@kernel-patches-bot
Copy link
Author

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=417431 irrelevant now. Closing PR.

@kernel-patches-bot kernel-patches-bot deleted the series/412571=>bpf-next branch January 19, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants