-
Notifications
You must be signed in to change notification settings - Fork 150
Allow attaching to bare tracepoints #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Master branch: 232164e |
|
Master branch: a2c2998 |
f7f5956 to
c5f8860
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=416125 expired. Closing PR. |
|
Master branch: 95204c9 |
c5f8860 to
f5d886f
Compare
|
Master branch: 95204c9 |
f5d886f to
3b9bf35
Compare
Some subsystems only have bare tracepoints (a tracepoint with no associated trace event) to avoid the problem of trace events being an ABI that can't be changed. From bpf presepective, bare tracepoints are what it calls RAW_TRACEPOINT(). Since bpf assumed there's 1:1 mapping, it relied on hooking to DEFINE_EVENT() macro to create bpf mapping of the tracepoints. Since bare tracepoints use DECLARE_TRACE() to create the tracepoint, bpf had no knowledge about their existence. By teaching bpf_probe.h to parse DECLARE_TRACE() in a similar fashion to DEFINE_EVENT(), bpf can find and attach to the new raw tracepoints. Enabling that comes with the contract that changes to raw tracepoints don't constitute a regression if they break existing bpf programs. We need the ability to continue to morph and modify these raw tracepoints without worrying about any ABI. Update Documentation/bpf/bpf_design_QA.rst to document this contract. Acked-by: Yonghong Song <yhs@fb.com> Signed-off-by: Qais Yousef <qais.yousef@arm.com>
Reuse module_attach infrastructure to add a new bare tracepoint to check we can attach to it as a raw tracepoint. Signed-off-by: Qais Yousef <qais.yousef@arm.com> Acked-by: Yonghong Song <yhs@fb.com>
|
Master branch: 3a6984e |
3b9bf35 to
fd01f0c
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=417431 irrelevant now. Closing PR. |
Pull request for series with
subject: Allow attaching to bare tracepoints
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=416125