Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nvim-ufo style preview] A gap on the right and no scroll bar with the right border set to empty #98

Closed
rockyzhang24 opened this issue Jan 17, 2023 · 3 comments
Closed

[nvim-ufo style preview] A gap on the right and no scroll bar with the right border set to empty #98

rockyzhang24 opened this issue Jan 17, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@rockyzhang24
Copy link
Contributor

rockyzhang24 commented Jan 17, 2023 •
edited
Loading

Neovim version (nvim -v | head -n1)

NVIM v0.9.0

Operating system/version

macOS 13.1

How to reproduce the issue

  1. Config bqf as below
require('bqf').setup {
  preview = {
    border_chars = { '', '', '─', '─', '', '', '', '', '█' },
  }
}
  1. run :vimgrep /\w\+/j % | copen under a buffer

Actual behavior

The preview window of nvim-ufo
bqf

The preview window of nvim-bqf.
The borders do not extend to the right end and the scroll bar does not show up.
ufo
@rockyzhang24 rockyzhang24 added the bug Something isn't working label Jan 17, 2023
@kevinhwang91
Copy link
Owner

kevinhwang91 commented Jan 18, 2023 •
edited
Loading

#75 (comment)
@mbenford Look like it's time to break change.

@rockyzhang24
Copy link
Contributor Author

Kill two birds with one stone 🐤

kevinhwang91 added a commit that referenced this issue Jun 6, 2023
@kevinhwang91
feat(preview)!: rework module (#98)
e9102f1 
1. Add `show_scroll_bar` option;
2. Add `border` option;
3. Add `winblend` option;
4. Delete `border_chars` option;
5. Change `BqfPreviewBorder` link to `FloatBorder`;
6. Add `BqfPreviewTitle` highlight;
7. Add `BqfPreviewThumb` highlight;
8. Add `BqfPreviewSbar` highlight;
@kevinhwang91
Copy link
Owner 

    require('bqf').setup({
        preview = {
            border = { '', '─', '', '', '', '─', '', '' },
        },
    })

should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rockyzhang24 @kevinhwang91