Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review: prepare_data() as generic #12

Closed
kgjerde opened this issue May 6, 2019 · 0 comments
Closed

Review: prepare_data() as generic #12

kgjerde opened this issue May 6, 2019 · 0 comments

Comments

@kgjerde
Copy link
Owner

kgjerde commented May 6, 2019

I would really like to see prepare_data() defined as a generic with one method for an input data.frame to make it easy to extend this in the future. For example, this would then make it easy to add a method for a quanteda corpus in that package to make it easy to hand off a quanteda corpus to corporaexplorer.

Implemented in 0e1f819

This is the first time I have defined generics, so please let me know if this is not what you had in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant