Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review: PhantomJS #14

Closed
kgjerde opened this issue May 6, 2019 · 1 comment
Closed

Review: PhantomJS #14

kgjerde opened this issue May 6, 2019 · 1 comment

Comments

@kgjerde
Copy link
Owner

kgjerde commented May 6, 2019 •
edited
Loading

Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.

Yes, but I had to install PhantomJS before I could get the tests to work. I suggest adding a note about this in the README.md on GitHub.

This appears to be a shinytest issue, and they claim that they provide a useful error message as well as function to install PhantomJS (rstudio/shinytest#175).

I am a bit afraid of further cluttering the README, so I have added a note in DESCRIPTION in commit b3fdd69. Please let me know if you think this is not sufficient.
@kgjerde kgjerde mentioned this issue May 6, 2019
Closed
36 tasks
kgjerde added a commit that referenced this issue May 10, 2019
@kgjerde
Add info about PhantomJS in README (#14)
c370f18
@kgjerde
Copy link
Owner Author

kgjerde commented May 10, 2019

@kbenoit, is something like c370f18 what you had in mind?

@kgjerde kgjerde closed this as completed Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kgjerde