Skip to content

Commit

Permalink
[Security Solution][Notes] - fix an issue that breaks the notes manag…
Browse files Browse the repository at this point in the history
…ement page, an enum value was missing from the api (elastic#196912)

## Summary

_**Notes: please ignore the spaces introduced in the first commit,
Webstorm is trying to be smart... CI should take care of fixing that in
a second commit shortly**_

This PR fixes a small issue that prevents the notes management page to
load. The issue comes from the fact that one of the enum values passed
to filter notes was missing from the open api spec. This issue was
introduced in this recent
[PR](elastic#195501).

Current notes management borken page
![Screenshot 2024-10-18 at 10 30
13 AM](https://github.com/user-attachments/assets/4926a62f-1ebf-4698-8a13-bf761d77f4ba)

This is the error in the network tab
![Screenshot 2024-10-18 at 10 30
29 AM](https://github.com/user-attachments/assets/90b56246-c116-4050-bcfa-2c6668274e74)

This PR fixes the issue
![Screenshot 2024-10-18 at 10 27
01 AM](https://github.com/user-attachments/assets/7d3338ce-ad73-4be5-b94c-15bcf0234680)

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit bf7c5aa)
  • Loading branch information
PhilippeOberti committed Oct 18, 2024
1 parent 070ea62 commit 024d273
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 4 deletions.
1 change: 1 addition & 0 deletions oas_docs/output/kibana.serverless.staging.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31687,6 +31687,7 @@ components:
Security_Timeline_API_AssociatedFilterType:
description: Filter notes based on their association with a document or saved object.
enum:
- all
- document_only
- saved_object_only
- document_and_saved_object
Expand Down
1 change: 1 addition & 0 deletions oas_docs/output/kibana.serverless.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31687,6 +31687,7 @@ components:
Security_Timeline_API_AssociatedFilterType:
description: Filter notes based on their association with a document or saved object.
enum:
- all
- document_only
- saved_object_only
- document_and_saved_object
Expand Down
1 change: 1 addition & 0 deletions oas_docs/output/kibana.staging.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40452,6 +40452,7 @@ components:
Security_Timeline_API_AssociatedFilterType:
description: Filter notes based on their association with a document or saved object.
enum:
- all
- document_only
- saved_object_only
- document_and_saved_object
Expand Down
1 change: 1 addition & 0 deletions oas_docs/output/kibana.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40452,6 +40452,7 @@ components:
Security_Timeline_API_AssociatedFilterType:
description: Filter notes based on their association with a document or saved object.
enum:
- all
- document_only
- saved_object_only
- document_and_saved_object
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import { Note } from '../model/components.gen';
*/
export type AssociatedFilterType = z.infer<typeof AssociatedFilterType>;
export const AssociatedFilterType = z.enum([
'all',
'document_only',
'saved_object_only',
'document_and_saved_object',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,11 @@ components:
AssociatedFilterType:
type: string
enum:
- document_only
- saved_object_only
- document_and_saved_object
- orphan
- all
- document_only
- saved_object_only
- document_and_saved_object
- orphan
description: Filter notes based on their association with a document or saved object.
DocumentIds:
oneOf:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -915,6 +915,7 @@ components:
AssociatedFilterType:
description: Filter notes based on their association with a document or saved object.
enum:
- all
- document_only
- saved_object_only
- document_and_saved_object
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -915,6 +915,7 @@ components:
AssociatedFilterType:
description: Filter notes based on their association with a document or saved object.
enum:
- all
- document_only
- saved_object_only
- document_and_saved_object
Expand Down

0 comments on commit 024d273

Please sign in to comment.