Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why password is needed + fixed KEY_RING_ID #3

Open
passcombo opened this issue Nov 12, 2019 · 3 comments
Open

Why password is needed + fixed KEY_RING_ID #3

passcombo opened this issue Nov 12, 2019 · 3 comments

Comments

@passcombo
Copy link

1 Why password is really needed?
I read password is needed for hdd encryption of keys (Secret keys), but checking the code I didn't notice any, so is the password/passhprase really needed? Also there is part of SecretKeys in Pgp object but they do not seem to be used ?
// Im still learning pgp, so maybe I dont get sth right...

  1. You have fixed KEY_RING_ID = email in the code, which is always used in building keys
@developerfromjokela
Copy link

Yeah, I think same. Why is the KEY_RING_ID fixed?

@kibotu
Copy link
Owner

kibotu commented Apr 10, 2020

no particular reason tbh, can be changed naturally. any suggestions how you guys would like it? random string? one time per install key?

@developerfromjokela
Copy link

developerfromjokela commented Apr 10, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants