-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #172, point to beginning for parsing headline #179
Conversation
To parse an org headline, the point needs to be at the beginning of it. After that, we move to the timestamp to parse it too.
Thanks for the fix! Do you have an example of a headline that this fixes? I'd like to add a regression test if possible. |
In my setup, all headlines are broken without this fix. I'll come up with a test for An example is
|
Thanks, I will look at this in a few hours |
Finally added the test! I've used some macros from I've also fixed another "bug", which only came up if your |
I tested this branch, can confirm it fixes #172 for my setup. Thanks! |
Another happy user here. All my old events are archived properly with this PR. Thanks! |
Thanks - I'd love to merge this, but the code to find
|
It's because we're trying to load the built-in Emacs |
I've debugged following the instructions in https://github.com/marketplace/actions/debugging-with-ssh, and it seems like we're using the built-in Org. We need to download Org from the Org package repository. |
I'm still having trouble figuring out how to retrieve the testing files from upstream. It may be best just to manually add |
@rhaps0dy I've been adding some additional fixes to the tests in #192. I've finally gotten it to the point where everything works except for org-gcal-test--headline-archive-old-event: https://github.com/kidd/org-gcal.el/runs/5656094259?check_suite_focus=true |
I'm going to close this in favor of #192. |
To parse an org headline, the point needs to be at the beginning of it.
After that, we move to the timestamp to parse it too.
Fixes #172