Merge pull request #444 from kids-first/str-checks

✅ Add test for model strings

tests/test_fields.py

@@ -1,7 +1,7 @@
 import pytest
 from django.db import models
 from django.contrib.auth import get_user_model
-from creator.fields import KFIDField
+from creator.fields import KFIDField, kf_id_generator
 from creator.studies.models import Study
 from creator.files.models import File
 
@@ -22,6 +22,14 @@ def test_kf_id_prefix_value(db):
     assert File.objects.get(kf_id=kf_id) == f
 
 
+def test_wrong_len():
+    """ Test that kf_ids must use a two character prefix """
+    with pytest.raises(ValueError) as err:
+        kf_id = kf_id_generator("ABC")
+
+        assert "of length 2" in err
+
+
 def test_user_display_name(db):
     user = User(username="user", first_name="Test", last_name=None)
     assert user.display_name == "Test"

tests/test_models.py

@@ -0,0 +1,21 @@
+import pytest
+import uuid
+
+from creator.studies.models import Study
+from creator.files.models import File, Version, DownloadToken
+from creator.projects.models import Project
+
+
+@pytest.mark.parametrize(
+    "model,expected",
+    [
+        (Study, "SD_00000001"),
+        (File, "SF_00000001"),
+        (Version, "FV_00000001"),
+        (Project, "test/test"),
+    ],
+)
+def test_str(model, expected):
+    """ Test string conversion functions """
+    obj = model(pk=expected)
+    assert str(obj) == expected