Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Add test for model strings #444

Merged
merged 2 commits into from
Aug 6, 2020
Merged

✅ Add test for model strings #444

merged 2 commits into from
Aug 6, 2020

Conversation

dankolbman
Copy link
Contributor

Adds general tests for models.

@dankolbman dankolbman added the refactor Something needs to be done better label Aug 3, 2020
@dankolbman dankolbman self-assigned this Aug 3, 2020
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #444 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
+ Coverage   91.92%   92.10%   +0.17%     
==========================================
  Files          61       61              
  Lines        2912     2912              
==========================================
+ Hits         2677     2682       +5     
+ Misses        235      230       -5     
Impacted Files Coverage Δ
creator/files/models.py 97.75% <0.00%> (+2.24%) ⬆️
creator/studies/models.py 100.00% <0.00%> (+2.27%) ⬆️
creator/projects/models.py 100.00% <0.00%> (+5.00%) ⬆️
creator/fields.py 100.00% <0.00%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf2d40...4caa484. Read the comment docs.

Copy link
Contributor

@XuTheBunny XuTheBunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍋

@dankolbman dankolbman merged commit 2b02f77 into master Aug 6, 2020
@dankolbman dankolbman deleted the str-checks branch August 6, 2020 02:49
dankolbman added a commit that referenced this pull request Aug 7, 2020
## Release 1.14.0

### Summary

- Emojis: 🐛 x2, ♻️ x3, ✅ x2, 🔧 x1, ✨ x1
- Categories: Fixes x2, Other Changes x6, Additions x1

### New features and changes

- [#433](#433) - 🐛 Fix file link in slack updates - [4266f2f](4266f2f) by [XuTheBunny](https://github.com/XuTheBunny)
- [#446](#446) - ♻️ Replace usernames in events with full names - [c9d459b](c9d459b) by [XuTheBunny](https://github.com/XuTheBunny)
- [#444](#444) - ✅ Add test for model strings - [2b02f77](2b02f77) by [dankolbman](https://github.com/dankolbman)
- [#445](#445) - ♻️ Refactor schemas - [faf2d40](faf2d40) by [dankolbman](https://github.com/dankolbman)
- [#443](#443) - ✅ Add test for unfound nodes - [d47e2a4](d47e2a4) by [dankolbman](https://github.com/dankolbman)
- [#442](#442) - 🔧 Increase task queue timeouts - [013dd82](013dd82) by [dankolbman](https://github.com/dankolbman)
- [#437](#437) - ♻️ Shift slack messages timestamp to be US/Eastern timezone - [ade3020](ade3020) by [XuTheBunny](https://github.com/XuTheBunny)
- [#438](#438) - ✨ Specify what change was made to a document in event message - [6482709](6482709) by [XuTheBunny](https://github.com/XuTheBunny)
- [#439](#439) - 🐛 Fix referral token event message with f-string - [06be010](06be010) by [XuTheBunny](https://github.com/XuTheBunny)
@dankolbman dankolbman mentioned this pull request Aug 7, 2020
alubneuski pushed a commit that referenced this pull request Sep 3, 2020
author Dan Kolbman <dankolbman@gmail.com> 1596824304 -0400
committer Alex Lubneuski <jenkins@d3b.center> 1599161926 -0400

:label: Release 1.14.0

- Emojis: 🐛 x2, ♻️ x3, ✅ x2, 🔧 x1, ✨ x1
- Categories: Fixes x2, Other Changes x6, Additions x1

- [#433](#433) - 🐛 Fix file link in slack updates - [4266f2f](4266f2f) by [XuTheBunny](https://github.com/XuTheBunny)
- [#446](#446) - ♻️ Replace usernames in events with full names - [c9d459b](c9d459b) by [XuTheBunny](https://github.com/XuTheBunny)
- [#444](#444) - ✅ Add test for model strings - [2b02f77](2b02f77) by [dankolbman](https://github.com/dankolbman)
- [#445](#445) - ♻️ Refactor schemas - [faf2d40](faf2d40) by [dankolbman](https://github.com/dankolbman)
- [#443](#443) - ✅ Add test for unfound nodes - [d47e2a4](d47e2a4) by [dankolbman](https://github.com/dankolbman)
- [#442](#442) - 🔧 Increase task queue timeouts - [013dd82](013dd82) by [dankolbman](https://github.com/dankolbman)
- [#437](#437) - ♻️ Shift slack messages timestamp to be US/Eastern timezone - [ade3020](ade3020) by [XuTheBunny](https://github.com/XuTheBunny)
- [#438](#438) - ✨ Specify what change was made to a document in event message - [6482709](6482709) by [XuTheBunny](https://github.com/XuTheBunny)
- [#439](#439) - 🐛 Fix referral token event message with f-string - [06be010](06be010) by [XuTheBunny](https://github.com/XuTheBunny)

:construction: Modified Jenkinsfiles
:wrench: Added JenkinsfileWorker

Added debugging statements

Removed bin/bash

:wrench: Added additional cert

:arrow_up: Upgrade redis dependencies

:bug: Correctly handle boolean settings

:bug: Add missing import

✨ Accept .xls file type for file analysis

✅ Update test for file format including xls

:recycle: Add study relation to versions

:card_file_box: Add study field to versions

:sparkles: Add createFile mutation

:recycle: Save version in transaction

:white_check_mark: Update test fixtures for new flow

:white_check_mark: Update analysis tests for new flow

:white_check_mark: Update event tests for new flow

:white_check_mark: Update upload tests for new flow

:fire: Deprecate direct file upload

:fire: Remove unused exception

The exception for boto errors should never be hit as the contained code
never utilizes boto.

:white_check_mark: Add tests

:pencil2: Fix app name for permission

:recycle: Do not return abandoned versions when listing

:sparkles: Allow version to be updated with new file

:white_check_mark: Add tests for linking version

:bug: Determine study from version or file

:white_check_mark: Increase analysis testing

:label: Release 1.14.1

- Emojis: 🐛 x1, ♻️ x1, ✨ x2, 🔧 x2, 🔥 x1
- Categories: Fixes x1, Other Changes x3, Additions x2, Removals x1

- [#457](#457) - 🐛 Determine study from version or file - [642c1ae](642c1ae) by [dankolbman](https://github.com/dankolbman)
- [#455](#455) - ♻️ Refactor document upload flow - [f825f58](f825f58) by [dankolbman](https://github.com/dankolbman)
- [#456](#456) - ✨ Accept .xls file type for file analysis - [c76d4d4](c76d4d4) by [XuTheBunny](https://github.com/XuTheBunny)
- [#454](#454) - 🔧 Dev Ops upgrades - [21e2d4a](21e2d4a) by [dankolbman](https://github.com/dankolbman)
- [#452](#452) - 🔧 Add SSL setting to RQ config - [03fd0c5](03fd0c5) by [dankolbman](https://github.com/dankolbman)
- [#449](#449) - ✨ File analyses - [c2e5a87](c2e5a87) by [dankolbman](https://github.com/dankolbman)
- [#450](#450) - 🔥 Remove vault - [4d6dc93](4d6dc93) by [dankolbman](https://github.com/dankolbman)

:bug: Check view_my_version permissions for downloads

:label: Release 1.14.2

- Emojis: 🐛 x1
- Categories: Fixes x1

- [#459](#459) - 🐛 Check view_my_version permissions for downloads - [6a8cad5](6a8cad5) by [dankolbman](https://github.com/dankolbman)

:sparkles: Validate document when saving

:sparkles: Add error handler for django validation

:white_check_mark: Add file_type validation tests

:card_file_box: Add migration for new file type

:recycle: Use explicit enum instead of graphene's

:sparkles: Add valid_types property to documents

:sparkles: Add valid_types to version

:bug: Catch UUID exceptions for tokens

:recycle: Make validation error formatting more precise
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Something needs to be done better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants