Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Add flag to enabled/disable DR bucket creation #580

Merged
merged 2 commits into from
Feb 24, 2021

Conversation

dankolbman
Copy link
Contributor

Allows configuration of whether or not to create DR buckets for new study buckets.

@dankolbman dankolbman added the devops Involves features of the deployment label Feb 19, 2021
@dankolbman dankolbman self-assigned this Feb 19, 2021
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #580 (e0375e9) into master (7c03def) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #580   +/-   ##
=======================================
  Coverage   93.44%   93.44%           
=======================================
  Files          92       92           
  Lines        4025     4028    +3     
=======================================
+ Hits         3761     3764    +3     
  Misses        264      264           
Impacted Files Coverage Δ
creator/buckets/buckets.py 97.93% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c03def...e0375e9. Read the comment docs.

Copy link
Contributor

@XuTheBunny XuTheBunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧇

Copy link
Member

@znatty22 znatty22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dankolbman dankolbman merged commit 428020b into master Feb 24, 2021
@dankolbman dankolbman deleted the dr-buckets-feature-flag branch February 24, 2021 15:57
dankolbman added a commit that referenced this pull request Feb 24, 2021
## Release 1.15.0

### Summary

- Emojis: ✨ x1, 🔧 x2, 🐛 x3, ⬆️ x2, 🐳 x1, 💄 x1
- Categories: Additions x1, Other Changes x3, Fixes x3, Ops x3

### New features and changes

- [#581](#581) - ✨ Add investigator name to study - [7c147b2](7c147b2) by [dankolbman](https://github.com/dankolbman)
- [#580](#580) - 🔧 Add flag to enabled/disable DR bucket creation - [428020b](428020b) by [dankolbman](https://github.com/dankolbman)
- [#573](#573) - 🔧 Add settings to status schema - [7c03def](7c03def) by [dankolbman](https://github.com/dankolbman)
- [#579](#579) - 🐛 Fix bugs from switching to Debian image - [40cf58c](40cf58c) by [znatty22](https://github.com/znatty22)
- [#578](#578) - ⬆️ Bump boto3 and requests - [fa5896a](fa5896a) by [znatty22](https://github.com/znatty22)
- [#577](#577) - 🐳 Switch to python:3.8-slim-buster docker img - [3ca47fd](3ca47fd) by [znatty22](https://github.com/znatty22)
- [#567](#567) - 💄 Clean up release messages - [843f0ba](843f0ba) by [dankolbman](https://github.com/dankolbman)
- [#572](#572) - ⬆️ Bump cryptography from 3.2 to 3.3.2 - [e046430](e046430) by [dependabot[bot]](https://github.com/apps/dependabot)
- [#566](#566) - 🐛 Only verify release id if its in the response - [d27077d](d27077d) by [dankolbman](https://github.com/dankolbman)
- [#564](#564) - 🐛 Add safeguards for trace sampler - [32e7f2e](32e7f2e) by [dankolbman](https://github.com/dankolbman)
@dankolbman dankolbman mentioned this pull request Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops Involves features of the deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants