Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add missing import #586

Merged
merged 1 commit into from
Feb 26, 2021
Merged

🐛 Add missing import #586

merged 1 commit into from
Feb 26, 2021

Conversation

dankolbman
Copy link
Contributor

Adds missing import and a test to hit a missing logic branch.

Closes #583

@dankolbman dankolbman added the bug Something isn't working label Feb 26, 2021
@dankolbman dankolbman self-assigned this Feb 26, 2021
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #586 (58ee142) into master (984f3cf) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #586      +/-   ##
==========================================
+ Coverage   92.41%   92.43%   +0.02%     
==========================================
  Files          99       99              
  Lines        4522     4523       +1     
==========================================
+ Hits         4179     4181       +2     
+ Misses        343      342       -1     
Impacted Files Coverage Δ
creator/analyses/analyzer.py 100.00% <100.00%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 984f3cf...58ee142. Read the comment docs.

Copy link
Member

@znatty22 znatty22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dankolbman dankolbman merged commit fdcd20a into master Feb 26, 2021
@dankolbman dankolbman deleted the missing-import branch February 26, 2021 17:55
dankolbman added a commit that referenced this pull request Feb 26, 2021
## Release 1.15.1

### Summary

- Emojis: 🐛 x1, 🔥 x1, ✨ x1
- Categories: Fixes x1, Removals x1, Additions x1

### New features and changes

- [#586](#586) - 🐛 Add missing import - [fdcd20a](fdcd20a) by [dankolbman](https://github.com/dankolbman)
- [#587](#587) - 🔥 Remove build_environments for worker - [7be9e36](7be9e36) by [dankolbman](https://github.com/dankolbman)
- [#574](#574) - ✨ Initial DataReview GraphQL API - [5903cbb](5903cbb) by [znatty22](https://github.com/znatty22)
@dankolbman dankolbman mentioned this pull request Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing GraphQLError import
2 participants