Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊 Configure release task logging directly #761

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Conversation

znatty22
Copy link
Member

Configures the logging for release tasks/jobs so that log statements make it to stdout. This is might not the long term solution since we don't necessarily want to have to configure logging for each individual module. But it is an important fix that will help us debug release issues until we figure out the longer term solution for API logging.

@znatty22 znatty22 self-assigned this Sep 27, 2021
@znatty22 znatty22 added the refactor Something needs to be done better label Sep 27, 2021
@znatty22 znatty22 marked this pull request as ready for review September 27, 2021 16:54
Copy link
Contributor

@dankolbman dankolbman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍀

@znatty22 znatty22 merged commit 7ecbb63 into master Sep 27, 2021
@znatty22 znatty22 deleted the fix-release-logging branch September 27, 2021 17:03
znatty22 added a commit that referenced this pull request Sep 27, 2021
## Release 1.19.6

### Summary

- Emojis: 🔊 x1, ♻️ x2, 🐛 x1
- Categories: Additions x1, Fixes x1, Other Changes x2

### New features and changes

- [#761](#761) - 🔊 Configure release task logging directly - [7ecbb63](7ecbb63) by [znatty22](https://github.com/znatty22)
- [#753](#753) - ♻️ Adjust validation rules and report - [cdabec7](cdabec7) by [znatty22](https://github.com/znatty22)
- [#741](#741) - ♻️ Restore old general file types and add new ones - [c3a6ecd](c3a6ecd) by [znatty22](https://github.com/znatty22)
- [#750](#750) - 🐛 Properly decode file content before validation - [77f1f42](77f1f42) by [znatty22](https://github.com/znatty22)
@znatty22 znatty22 mentioned this pull request Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Something needs to be done better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants