Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing UICollectionView cell tapping #1106

Merged
merged 1 commit into from
Apr 22, 2019
Merged

Fixing UICollectionView cell tapping #1106

merged 1 commit into from
Apr 22, 2019

Conversation

harleyjcooper
Copy link
Contributor

When tapping a UICollectionView, sometimes the data in the cell might change prior to being displayed, since we're only pulling it from the data source. So here we simulate the cell appearing onscreen.

justinseanmartin
justinseanmartin approved these changes Apr 21, 2019
View reviewed changes
Copy link
Contributor

@justinseanmartin justinseanmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be nice if there were a test added to the functional test suite to ensure this doesn't regress, but it also isn't the end of the world.

@harleyjcooper harleyjcooper mentioned this pull request Apr 22, 2019
Open
@harleyjcooper
Copy link
Contributor Author

LGTM. Would be nice if there were a test added to the functional test suite to ensure this doesn't regress, but it also isn't the end of the world.

This would take a bit of effort in rearchitecting the CollectionViewController - it would need us to implement collectionView:willDisplayCell:forItemAtIndexPath instead of collectionView:cellForItemAtIndexPath. I created #1107 to track this.

@harleyjcooper harleyjcooper merged commit 0a5fe2d into kif-framework:master Apr 22, 2019
@harleyjcooper harleyjcooper deleted the harley/fix-collectionview-scrolling branch April 22, 2019 14:26
@justinseanmartin justinseanmartin mentioned this pull request Oct 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinseanmartin justinseanmartin justinseanmartin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harleyjcooper @justinseanmartin