Issue #1152: Fix crash in _setIsFirstTouchInView and setIsTap for iOS 14 #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinseanmartin
approved these changes
Jun 30, 2020
dostrander
changed the title
justinseanmartin
changed the title
segiddins
reviewed
Jul 1, 2020
|
|
||
| // We modify the touchFlags ivar struct directly. | ||
| // First entry is _firstTouchForView | ||
| Ivar flagsIvar = class_getInstanceVariable(object_getClass(self), "_touchFlags"); |
There was a problem hiding this comment.
Should we assert that the the ivar exists?
There was a problem hiding this comment.
Good idea! Given how that code writes into memory, it would corrupt the isa pointer if this is not found.
There was a problem hiding this comment.
@dostrander ^ making sure you saw this
There was a problem hiding this comment.
Yep added it to the xcode upgrades PR. Going to split some of the issues I found with it up today and early next week and i'll split that one out as well.
ignazioc
pushed a commit
to technology-ebay-de/KIF
that referenced
this pull request
Sep 18, 2020
vijaytholpadi
added a commit
to carousell/TTTAttributedLabel
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #1152
This uses @steipete's fix for iOS 14 crashing outlined here.
I've tested using iOS 14 and earlier iOS versions to make sure this works as intended.
I am currently following the thread here to see if any new information pops up around this and will be investigating this more in the future to see if there is a better longterm solution, however to get folks unblocked this should work for now.