From 274beb10370c9b3990b4e9f02c03f15fd601a597 Mon Sep 17 00:00:00 2001
From: Keaton Brown <linux.keaton@gmail.com>
Date: Sat, 3 Aug 2024 10:52:37 -0500
Subject: [PATCH] Add test for Popup signal handling (tests  #87626)

---
 tests/scene/test_popup.h | 75 ++++++++++++++++++++++++++++++++++++++++
 tests/test_main.cpp      |  1 +
 2 files changed, 76 insertions(+)
 create mode 100644 tests/scene/test_popup.h

diff --git a/tests/scene/test_popup.h b/tests/scene/test_popup.h
new file mode 100644
index 000000000000..955721ce5700
--- /dev/null
+++ b/tests/scene/test_popup.h
@@ -0,0 +1,75 @@
+/**************************************************************************/
+/*  test_viewport.h                                                       */
+/**************************************************************************/
+/*                         This file is part of:                          */
+/*                             GODOT ENGINE                               */
+/*                        https://godotengine.org                         */
+/**************************************************************************/
+/* Copyright (c) 2014-present Godot Engine contributors (see AUTHORS.md). */
+/* Copyright (c) 2007-2014 Juan Linietsky, Ariel Manzur.                  */
+/*                                                                        */
+/* Permission is hereby granted, free of charge, to any person obtaining  */
+/* a copy of this software and associated documentation files (the        */
+/* "Software"), to deal in the Software without restriction, including    */
+/* without limitation the rights to use, copy, modify, merge, publish,    */
+/* distribute, sublicense, and/or sell copies of the Software, and to     */
+/* permit persons to whom the Software is furnished to do so, subject to  */
+/* the following conditions:                                              */
+/*                                                                        */
+/* The above copyright notice and this permission notice shall be         */
+/* included in all copies or substantial portions of the Software.        */
+/*                                                                        */
+/* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,        */
+/* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF     */
+/* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. */
+/* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY   */
+/* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,   */
+/* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE      */
+/* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.                 */
+/**************************************************************************/
+
+#ifndef TEST_POPUP_H
+#define TEST_POPUP_H
+
+#include "scene/gui/popup.h"
+#include "scene/gui/control.h"
+#include "scene/main/window.h"
+#include "core/object/worker_thread_pool.h"
+
+#include "tests/test_macros.h"
+#include "tests/test_tools.h"
+
+
+namespace TestPopup {
+
+TEST_CASE("[SceneTree][Popup]") {
+	Window *root = SceneTree::get_singleton()->get_root();
+	root->set_embedding_subwindows(true);
+	Control *parent = memnew(Control);
+	Popup *popup = memnew(Popup);
+
+	// Scene tree:
+	// - root (Window) (Default visible: true)
+	//   - parent (Control) (Default visible: true)
+	//     - popup (Popup) (Default visible: false)
+
+	root->add_child(parent);
+	parent->add_child(popup);
+	ErrorDetector ed;
+
+	SUBCASE("[_initialize_visiable_parents] Calling twice without deinitializing should first disconnect current connections (fix #87626).") {
+		popup->set_visible(true);
+		CHECK_FALSE(ed.has_error);
+		ed.clear();
+		ERR_PRINT_OFF;
+		popup->notification(popup->NOTIFICATION_VISIBILITY_CHANGED);
+		ERR_PRINT_ON;
+		CHECK_FALSE(ed.has_error);
+		ed.clear();
+	}
+
+}
+
+} // namespace TestPopup
+
+#endif // TEST_POPUP_H
diff --git a/tests/test_main.cpp b/tests/test_main.cpp
index edadc52a1639..99d4b23c15a2 100644
--- a/tests/test_main.cpp
+++ b/tests/test_main.cpp
@@ -118,6 +118,7 @@
 #include "tests/scene/test_packed_scene.h"
 #include "tests/scene/test_path_2d.h"
 #include "tests/scene/test_path_follow_2d.h"
+#include "tests/scene/test_popup.h"
 #include "tests/scene/test_sprite_frames.h"
 #include "tests/scene/test_theme.h"
 #include "tests/scene/test_timer.h"