Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

black: Add black to project #123

Closed
wants to merge 1 commit into from

Conversation

evanpurkhiser
Copy link
Contributor

@evanpurkhiser evanpurkhiser commented Oct 30, 2024

  • Adds black to CI workflow
  • Adds a new tox format command
  • Locks black to the last version supporting python 2
  • Configures black using pyproject.toml (unfortunately it cannot be configured using tox.ini, see Support Configuration via tox.ini psf/black#2172)

Please don't merge yet until I've merged all the PRs to complete formatting of the project. The PR should fail before then!

Part of #99

tox.ini Outdated Show resolved Hide resolved
@kiorky
Copy link
Owner

kiorky commented Oct 30, 2024

  • Configures black using pyproject.toml (unfortunately it cannot be configured using tox.ini, see

another solution is to use brunette, a wrapper that support setup.cfg, i was already doing this in my local copy, but afterall just keep with black.

@evanpurkhiser evanpurkhiser force-pushed the black-ci branch 2 times, most recently from ff5ad06 to 3d12d29 Compare October 30, 2024 18:34
pyproject.toml Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
pyproject.toml Outdated
@@ -0,0 +1,17 @@
[tool.black]
line-lenghth = 119
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commited this by error on you fork while testing github ide... , just to let you know.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no problem!

@evanpurkhiser
Copy link
Contributor Author

Updated to use line-length 119. For my newer PRs i'll be formatting using line length 119, especially tests.

- Adds a new tox `check-format` command
- Locks black to the last version supporting python 2
- Configures black using pyproject.toml (unfortunately it cannot be
  configured using tox.ini, see psf/black#2172)
@kiorky
Copy link
Owner

kiorky commented Oct 31, 2024

already merged.

@kiorky kiorky closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants