Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Housekeeping: Reconfigure chromatic #3485

Closed
wants to merge 5 commits into from
Closed

Housekeeping: Reconfigure chromatic #3485

wants to merge 5 commits into from

Conversation

RasmusKjeldgaard
Copy link
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard commented May 30, 2024 •
edited
Loading

Which issue does this PR close?

This PR closes #3388

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic May 30, 2024 14:09 Inactive
@RasmusKjeldgaard RasmusKjeldgaard force-pushed the enhancement/3388-reconfig-chromatic branch from dc696f8 to e0d4a19 Compare May 30, 2024 14:44
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic May 30, 2024 14:47 Inactive
@RasmusKjeldgaard RasmusKjeldgaard force-pushed the enhancement/3388-reconfig-chromatic branch from e0d4a19 to 9a9cf2b Compare May 30, 2024 15:33
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic May 30, 2024 16:00 Inactive
@RasmusKjeldgaard RasmusKjeldgaard marked this pull request as draft May 30, 2024 20:52
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 2, 2024 18:33 Inactive
@RasmusKjeldgaard RasmusKjeldgaard changed the base branch from develop to enhancement/3443-add-composite-component-workspace June 2, 2024 20:22
@RasmusKjeldgaard RasmusKjeldgaard force-pushed the enhancement/3388-reconfig-chromatic branch from c2606a0 to 3701d62 Compare June 6, 2024 13:31
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 6, 2024 13:42 Inactive
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 6, 2024 19:07 Inactive
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 6, 2024 19:46 Inactive
@RasmusKjeldgaard RasmusKjeldgaard force-pushed the enhancement/3388-reconfig-chromatic branch 2 times, most recently from 7fbf5f3 to 0c1c149 Compare June 6, 2024 19:48
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 6, 2024 19:50 Inactive
@RasmusKjeldgaard RasmusKjeldgaard force-pushed the enhancement/3388-reconfig-chromatic branch from 0c1c149 to f17f44e Compare June 6, 2024 19:51
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 6, 2024 19:52 Inactive
@RasmusKjeldgaard RasmusKjeldgaard force-pushed the enhancement/3388-reconfig-chromatic branch from f17f44e to 36a9915 Compare June 6, 2024 19:56
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 6, 2024 20:00 Inactive
@RasmusKjeldgaard RasmusKjeldgaard force-pushed the enhancement/3388-reconfig-chromatic branch from 36a9915 to bb4c7d9 Compare June 6, 2024 20:03
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 6, 2024 20:08 Inactive
@RasmusKjeldgaard RasmusKjeldgaard force-pushed the enhancement/3388-reconfig-chromatic branch from bb4c7d9 to 9a1108a Compare June 6, 2024 20:17
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 6, 2024 20:21 Inactive
@RasmusKjeldgaard RasmusKjeldgaard force-pushed the enhancement/3388-reconfig-chromatic branch 2 times, most recently from 00c10f1 to d753381 Compare June 6, 2024 20:31
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 6, 2024 20:31 Inactive
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 6, 2024 20:36 Inactive
@RasmusKjeldgaard RasmusKjeldgaard force-pushed the enhancement/3388-reconfig-chromatic branch from d753381 to 1ace1c5 Compare June 6, 2024 20:41
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 7, 2024 08:00 Inactive
@RasmusKjeldgaard RasmusKjeldgaard force-pushed the enhancement/3388-reconfig-chromatic branch from 7046203 to c85a071 Compare June 7, 2024 08:20
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 7, 2024 08:25 Inactive
@RasmusKjeldgaard RasmusKjeldgaard force-pushed the enhancement/3388-reconfig-chromatic branch from d4d2819 to c9d484b Compare June 7, 2024 09:20
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 7, 2024 09:25 Inactive
@RasmusKjeldgaard RasmusKjeldgaard force-pushed the enhancement/3388-reconfig-chromatic branch 4 times, most recently from 88d50a7 to ba1d043 Compare June 10, 2024 09:34
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 10, 2024 09:38 Inactive
@RasmusKjeldgaard RasmusKjeldgaard force-pushed the enhancement/3388-reconfig-chromatic branch from ba1d043 to fddb999 Compare June 10, 2024 10:14
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 10, 2024 10:19 Inactive
@RasmusKjeldgaard RasmusKjeldgaard force-pushed the enhancement/3388-reconfig-chromatic branch from fddb999 to 36b23e7 Compare June 10, 2024 10:29
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 10, 2024 10:33 Inactive
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 10, 2024 10:43 Inactive
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 10, 2024 10:50 Inactive
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 10, 2024 11:18 Inactive
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 10, 2024 12:23 Inactive
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 10, 2024 13:21 Inactive
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 10, 2024 14:47 Inactive
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 10, 2024 15:06 Inactive
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 11, 2024 08:34 Inactive
@RasmusKjeldgaard RasmusKjeldgaard force-pushed the enhancement/3388-reconfig-chromatic branch from 15c0cf2 to ba4f5f9 Compare June 11, 2024 09:21
@github-actions github-actions bot temporarily deployed to pr-3388-reconfig-chromatic June 11, 2024 09:26 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaltoft jkaltoft Awaiting requested review from jkaltoft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Testing] Re-configure Chromatic CI workflow
1 participant
@RasmusKjeldgaard