Fixed Update_complex_type_with_view_mapping tests

Author: kirolous-nashaat

src/EFCore.Relational/Query/RelationalQueryableMethodTranslatingExpressionVisitor.ExecuteUpdate.cs

@@ -300,7 +300,7 @@ bool TryTranslateMemberAccess(
                     [NotNullWhen(true)] out IPropertyBase? property)
                 {
                     if (IsMemberAccess(expression, QueryCompilationContext.Model, out var baseExpression, out var member)
-                        && _sqlTranslator.TryBindMember(_sqlTranslator.Visit(baseExpression), member, out var target, out var targetProperty))
+                        && _sqlTranslator.TryBindMember(_sqlTranslator.Visit(baseExpression), member, out var target, out var targetProperty, forUpdate: true))
                     {
                         translation = target;
                         property = targetProperty;
@@ -540,7 +540,7 @@ void ProcessComplexType(StructuralTypeShaperExpression shaperExpression, Express
                             RelationalStrings.ExecuteUpdateOverJsonIsNotSupported(complexProperty.ComplexType.DisplayName()));
                     }
 
-                    var nestedShaperExpression = (StructuralTypeShaperExpression)projection.BindComplexProperty(complexProperty);
+                    var nestedShaperExpression = (StructuralTypeShaperExpression)projection.BindComplexProperty(complexProperty, forUpdate: true);
                     var nestedValueExpression = CreateComplexPropertyAccessExpression(valueExpression, complexProperty);
                     ProcessComplexType(nestedShaperExpression, nestedValueExpression);
                 }
@@ -635,7 +635,7 @@ SqlParameterExpression parameter
                                 StructuralType: IComplexType,
                                 ValueBufferExpression: StructuralTypeProjectionExpression projection
                             }
-                                => projection.BindComplexProperty(complexProperty),
+                                => projection.BindComplexProperty(complexProperty, forUpdate: true),
 
                             _ => throw new UnreachableException()
                         };

src/EFCore.Relational/Query/RelationalSqlTranslatingExpressionVisitor.cs

@@ -1219,7 +1219,8 @@ public virtual bool TryBindMember(
         Expression? source,
         MemberIdentity member,
         [NotNullWhen(true)] out Expression? expression,
-        [NotNullWhen(true)] out IPropertyBase? property)
+        [NotNullWhen(true)] out IPropertyBase? property,
+        bool forUpdate = false)
     {
         if (source is not StructuralTypeReferenceExpression typeReference)
         {
@@ -1247,7 +1248,7 @@ public virtual bool TryBindMember(
 
         if (complexProperty is not null)
         {
-            expression = BindComplexProperty(typeReference, complexProperty);
+            expression = BindComplexProperty(typeReference, complexProperty, forUpdate: forUpdate);
             property = complexProperty;
             return true;
         }
@@ -1359,7 +1360,7 @@ private SqlExpression BindProperty(StructuralTypeReferenceExpression typeReferen
         }
     }
 
-    private Expression BindComplexProperty(StructuralTypeReferenceExpression typeReference, IComplexProperty complexProperty)
+    private Expression BindComplexProperty(StructuralTypeReferenceExpression typeReference, IComplexProperty complexProperty, bool forUpdate = false)
     {
         switch (typeReference)
         {
@@ -1370,7 +1371,7 @@ private Expression BindComplexProperty(StructuralTypeReferenceExpression typeRef
                         // TODO: Move all this logic into StructuralTypeProjectionExpression, #31376
                         Check.DebugAssert(structuralTypeProjection.IsNullable == shaper.IsNullable, "Nullability mismatch");
 
-                        return structuralTypeProjection.BindComplexProperty(complexProperty) switch
+                        return structuralTypeProjection.BindComplexProperty(complexProperty, forUpdate: forUpdate) switch
                         {
                             StructuralTypeShaperExpression s => new StructuralTypeReferenceExpression(s),
                             CollectionResultExpression c => c,

src/EFCore.Relational/Query/SqlExpressions/SelectExpression.cs

@@ -2855,14 +2855,15 @@ static TableExpressionBase FindRootTableExpressionForColumn(SelectExpression sel
     [EntityFrameworkInternal]
     public static Expression GenerateComplexPropertyShaperExpression(
         StructuralTypeProjectionExpression containerProjection,
-        IComplexProperty complexProperty)
+        IComplexProperty complexProperty,
+        bool forUpdate = false)
     {
         var complexType = complexProperty.ComplexType;
         var propertyExpressionMap = new Dictionary<IProperty, ColumnExpression>();
 
         // We do not support complex type splitting, so we will only ever have a single table/view mapping to it.
         // See Issue #32853 and Issue #31248
-        var complexTypeTable = complexType.GetViewOrTableMappings().Single().Table;
+        ITableBase complexTypeTable = forUpdate ? complexType.GetTableMappings().Single().Table : complexType.GetViewOrTableMappings().Single().Table;
 
         if (!containerProjection.TableMap.TryGetValue(complexTypeTable, out var tableAlias))
         {

src/EFCore.Relational/Query/StructuralTypeProjectionExpression.cs

@@ -369,9 +369,14 @@ public virtual ColumnExpression BindProperty(IProperty property)
     ///     Binds a complex property with this structural type projection to get a shaper expression for the target complex type.
     /// </summary>
     /// <param name="complexProperty">A complex property to bind.</param>
+    /// <param name="forUpdate">Is the mapping for read (false) or update (true).</param>
     /// <returns>A shaper expression for the target complex type.</returns>
-    public virtual Expression BindComplexProperty(IComplexProperty complexProperty)
+    public virtual Expression BindComplexProperty(IComplexProperty complexProperty, bool forUpdate = false)
     {
+        if (forUpdate)
+        {
+            return SelectExpression.GenerateComplexPropertyShaperExpression(this, complexProperty, forUpdate: true);
+        }
         if (_complexPropertyCache is null || !_complexPropertyCache.TryGetValue(complexProperty, out var resultShaper))
         {
             _complexPropertyCache ??= new Dictionary<IComplexProperty, Expression>();