v1.2.0 enters infinite loop #162
Comments
34 tasks
RaduBerinde
added a commit
to RaduBerinde/cockroach
that referenced
this issue
Jan 10, 2019
Update all deps except: - errcheck (due to kisielk/errcheck#162) - honnef.co/go/tools (requires refactoring) - some `github.com/cockroachdb/` deps which have been updated for go1.11. Changes: Azure/azure-storage-blob-go@5152f14...45d0c5e IBM/sarama@bbdbe64...879f631 aws/aws-sdk-go@ddc06f9...1f8a246 axiomhq/hyperloglog@e8c19f1...4b99d0c cenkalti/backoff@62661b4...1e4cf3d cockroachdb/circuitbreaker@4f5b168...3e861b2 distribution/distribution@40b7b58...91b0f05 moby/moby@a4a816b...b4842cf go-ole/go-ole@a41e3c4...39dc848 go-sql-driver/mysql@60d456a...c45f530 google/go-github@35781f7...a5cb647 google/pprof@3ea8567...e84dfd6 googleapis/gax-go@b001040...c8a15ba grpc-ecosystem/grpc-gateway@9258377...aeab1d9 jmespath/go-jmespath@0b12d6b...c2b33e8 linkedin/goavro@1beee2a...af12b3c mattn/go-runewidth@ce7b0b5...3ee7d81 montanaflynn/stats@db72e6c...945b007 pkg/errors@645ef00...ba968bf prometheus/client_model@5c3871d...f287a10 prometheus/common@4724e92...2998b13 prometheus/procfs@1dc9a6c...b1a0a9a shirou/gopsutil@0f70a4a...ccc1c10 sirupsen/logrus@bcd833d...e1e72e9 stretchr/testify@f35b8ab...ffdc059 etcd-io/etcd@1900a8e...fae6e92 golang/crypto@505ab14...ff983b9 golang/net@351d144...1e06a53 golang/sync@42b3178...37e7f08 golang/sys@70b957f...48ac38b golang/tools@bcd4e47...d30e00c googleapis/google-api-go-client@9c79dee...19e022d golang/appengine@150dc57...e9657d8 Informs cockroachdb#30774. Release note: None
RaduBerinde
added a commit
to RaduBerinde/cockroach
that referenced
this issue
Jan 11, 2019
Update all deps except: - errcheck (due to kisielk/errcheck#162) - honnef.co/go/tools (requires refactoring) - some `github.com/cockroachdb/` deps which have been updated for go1.11. Changes: Azure/azure-storage-blob-go@5152f14...45d0c5e IBM/sarama@bbdbe64...879f631 aws/aws-sdk-go@ddc06f9...1f8a246 axiomhq/hyperloglog@e8c19f1...4b99d0c cenkalti/backoff@62661b4...1e4cf3d cockroachdb/circuitbreaker@4f5b168...3e861b2 distribution/distribution@40b7b58...91b0f05 moby/moby@a4a816b...b4842cf go-ole/go-ole@a41e3c4...39dc848 go-sql-driver/mysql@60d456a...c45f530 google/go-github@35781f7...a5cb647 google/pprof@3ea8567...e84dfd6 googleapis/gax-go@b001040...c8a15ba grpc-ecosystem/grpc-gateway@9258377...aeab1d9 jmespath/go-jmespath@0b12d6b...c2b33e8 linkedin/goavro@1beee2a...af12b3c mattn/go-runewidth@ce7b0b5...3ee7d81 montanaflynn/stats@db72e6c...945b007 pkg/errors@645ef00...ba968bf prometheus/client_model@5c3871d...f287a10 prometheus/common@4724e92...2998b13 prometheus/procfs@1dc9a6c...b1a0a9a shirou/gopsutil@0f70a4a...ccc1c10 sirupsen/logrus@bcd833d...e1e72e9 stretchr/testify@f35b8ab...ffdc059 etcd-io/etcd@1900a8e...fae6e92 golang/crypto@505ab14...ff983b9 golang/net@351d144...1e06a53 golang/sync@42b3178...37e7f08 golang/sys@70b957f...48ac38b golang/tools@bcd4e47...d30e00c googleapis/google-api-go-client@9c79dee...19e022d golang/appengine@150dc57...e9657d8 Informs cockroachdb#30774. Release note: None
|
This was with go 1.10. |
|
Looks like it works fine with go 1.11. Possibly related to golang/go#29427 |
|
Hmm, I guess we can chalk it up to that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running
errcheckon the CockroachDB code.With errcheck v1.1.0:
With v1.2.0, the same command doesn't finish (I waited 10 minutes). I also notice that a single core is pinned at 100% while it's running.
The text was updated successfully, but these errors were encountered: