Improve: Update Gradle version #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you take this to 4.6? It was released and is a new build. |
|
@mhutti1 Actually Android Studio 3.2 which is in development comes with 4.5, thus I thought it's better to go with the same version. However, I have updated the PR. |
|
@mhutti1 Please review. I can't figure out the reason behind the |
mhutti1
approved these changes
Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to #518
Changes: Update the Gradle version to
4.6. If we are going to use the latest, why not the best? Pros can be found here. Tested and verified.Screenshots/GIF for the change: N/A