From 70d7a4cefe0b8ae9dfe13e000e89120d87d458dc Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Sun, 29 Jul 2018 19:26:27 -0700
Subject: [PATCH] test: improve reliability in http2-session-timeout

Use `setImmediate()` instead of `setTimeout()` to improve robustness of
test-http2-session-timeout.

Fixes: https://github.com/nodejs/node/issues/20628

PR-URL: https://github.com/nodejs/node/pull/22026
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
---
 test/sequential/test-http2-session-timeout.js | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/test/sequential/test-http2-session-timeout.js b/test/sequential/test-http2-session-timeout.js
index 48e98998c700b6..5c4f047b338e9c 100644
--- a/test/sequential/test-http2-session-timeout.js
+++ b/test/sequential/test-http2-session-timeout.js
@@ -3,13 +3,12 @@
 const common = require('../common');
 if (!common.hasCrypto)
   common.skip('missing crypto');
-const h2 = require('http2');
+const http2 = require('http2');
 
 const serverTimeout = common.platformTimeout(200);
-const callTimeout = common.platformTimeout(20);
 const mustNotCall = common.mustNotCall();
 
-const server = h2.createServer();
+const server = http2.createServer();
 server.timeout = serverTimeout;
 
 server.on('request', (req, res) => res.end());
@@ -19,7 +18,7 @@ server.listen(0, common.mustCall(() => {
   const port = server.address().port;
 
   const url = `http://localhost:${port}`;
-  const client = h2.connect(url);
+  const client = http2.connect(url);
   const startTime = process.hrtime();
   makeReq();
 
@@ -37,7 +36,7 @@ server.listen(0, common.mustCall(() => {
       const diff = process.hrtime(startTime);
       const milliseconds = (diff[0] * 1e3 + diff[1] / 1e6);
       if (milliseconds < serverTimeout * 2) {
-        setTimeout(makeReq, callTimeout);
+        setImmediate(makeReq);
       } else {
         server.removeListener('timeout', mustNotCall);
         server.close();