-
Notifications
You must be signed in to change notification settings - Fork 132
some cleanups and rename on start type #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ) | ||
|
|
||
| var kmeshStartType StartType | ||
| var kmeshExitType StartType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comments about when to use kmeshExitType and when to use kmeshStartType, it is also very confusing that they are both of type StartType, maybe we need better naming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kmeshStartType is used during bootsttap
kmeshExitType is used during exit, to indicate whether keep bpf prog/maps or not
Previously one var is used to indicate both, confusing to me
pkg/bpf/bpf_restart_test.go
Outdated
| kmeshExitType = Restart | ||
| bpfLoader.Stop() | ||
| assert.Equal(t, Restart, GetStartType(), "set kmesh close status:Restart failed") | ||
| assert.Equal(t, Restart, GetExitType(), "set kmesh close status:Restart failed") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| assert.Equal(t, Restart, GetExitType(), "set kmesh close status:Restart failed") | |
| assert.Equal(t, Restart, GetExitType(), "set kmesh exit type to Restart failed") |
62a7342 to
a626a99
Compare
Codecov ReportAttention: Patch coverage is
... and 14 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
Signed-off-by: Zhonghu Xu <xuzhonghu@huawei.com>
a626a99 to
daf352a
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: supercharge-xsy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for you're reviewer:
Does this PR introduce a user-facing change?: