Add license scan report and status #250
Conversation
Signed off by: fossabot <badges@fossa.com>
✅ Deploy Preview for kmesh-net ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Welcome @fossabot! It looks like this is your first PR to kmesh-net/website 🎉 |
Summary of ChangesHello @fossabot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates FOSSA for license compliance tracking by updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, likely automated by FOSSA, adds a license scan status badge to the README.md. While adding the badge is a good idea, there are a couple of placement and formatting issues. I've left comments to address them: one badge is incorrectly placed within a Markdown example, and the new 'License' section has some minor formatting problems (an extra blank line and a missing final newline).
|
|
||
| ```md | ||
|  | ||
| [](https://app.fossa.com/projects/git%2Bgithub.com%2Fkmesh-net%2Fwebsite?ref=badge_shield) |
There was a problem hiding this comment.
The FOSSA status badge has been added to an example code block for how to include images in Markdown. This is likely to be confusing for contributors, as it's not part of the standard syntax for images and doesn't belong in a generic example. The badge is more appropriately placed only in the new "License" section.
|
|
||
|
|
||
| ## License | ||
| [](https://app.fossa.com/projects/git%2Bgithub.com%2Fkmesh-net%2Fwebsite?ref=badge_large) |
There was a problem hiding this comment.
There are a couple of minor formatting issues here. There's an extra blank line before the ## License heading, and the file is missing a final newline character. It's good practice to have a single blank line separating sections and to end files with a newline for POSIX compatibility and to avoid issues with some tools.
| ## License | |
| [](https://app.fossa.com/projects/git%2Bgithub.com%2Fkmesh-net%2Fwebsite?ref=badge_large) | |
| ## License | |
| [](https://app.fossa.com/projects/git%2Bgithub.com%2Fkmesh-net%2Fwebsite?ref=badge_large) | |
|
@yashisrani can you help look into the license issue, scanned by fossa |
|
4 participants
Your FOSSA integration was successful! Attached in this PR is a badge and license report to track scan status in your README.
Below are docs for integrating FOSSA license checks into your CI: