improved mobile navbar/sidebar #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sidebar is hidden and all menu items moved to hamburger menu on mobile devices
|
Yay, this is cool! Will test locally and merge soon. |
-removed redundant code -fixed an issue with emitting data to App.vue
|
Checked this out locally and it works fine. eslint throws a bunch of linting errors though. Could you please retain the indentation of the original |
fixed linting errors
|
uggh... |
- Fix indentation and line lengths. - Simplify prop definitions in the Navigation component. - Remove redundant computed methods and use prop variables directly in the Navigation compontent. - Simplify menu rendering logic by: removing isSidebar, showLogout and using simpler v-if / else in the parent instead of the Navigation component.
|
Added some minor improvements to to the PR. Once you review and confirm, this is good to be merged. |
removed orphaned isSideBar Boolean
|
yay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sidebar is hidden and all menu items moved to hamburger menu on mobile devices